Purpose

The high_water_mark_query_parameter module provides a simple interface to add/edit the parameter added to a complex query for boosting the query performance.

This way a large number of row is simply skipped while fetching the records, results in performance gain by 80%-95% with any kind of complex query.

Best Usage

This is a useful module for top "n", most recent "n", type of queries.
Often sites show latest n records on their home page. Such queries normally process thousands of records to return just 5-20 records. Such complex queries are best suited to utilize this feature.

Link to the project : http://drupal.org/sandbox/chandrashekhar_srijan/1158980

Comments

chandrashekhar_srijan’s picture

chandrashekhar_srijan commented

Hi community,
Please have look to this.

jordojuice’s picture

jordojuice commented
Priority: Normal » Critical

Hi, we apologize for the long wait! I am elevating the priority of your application according to priority guidelines.

chandrashekhar_srijan’s picture

chandrashekhar_srijan commented

The status has been "critical" for 6 weeks.
Can someone review this. I can provide more details about the project if the project application is not clear.

chandrashekhar_srijan’s picture

chandrashekhar_srijan commented

"Jai ho"

attiks’s picture

attiks commented

I did a quick Coder review to check the Coding Standards, see below.

sites/all/modules/high_water_mark_query_parameter/high_water_mark_query_parameter.module:
+261: [critical] Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.
+261: [normal] The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.

sites/all/modules/high_water_mark_query_parameter/high_water_mark_query_parameter.install:
+-1: [normal] @file block missing

Status Messages:
Coder found 1 projects, 2 files, 1 critical warnings, 2 normal warnings, 0 warnings were flagged to be ignored

attiks’s picture

attiks commented
Status: Needs review » Needs work

Some other remarks and questions:
1/ The field lengths of your schema look arbitrary and can be too small, consider converting them to text fields
2/ you have a funny construction inside high_water_mark_query_parameter_add_parameter, better have a look at hook_menu, you can define placeholders that you can pass to your function
3/ why global $base_url; inside high_water_mark_query_parameter_add_parameter
4/ use theme_table to output tables
5/ as far as i can see people have to manually change the parameter once in a while, so if they don't they loose the benefit?
6/ do you have any performance reports to show the speed improvements?
7/ how do you propose this will work with queries from core or other modules?

misc’s picture

misc commented

There are no contact adres for applicant, and the application has been marked as need work for 21 weeks (http://drupal.org/node/894256#abandoned-modules), should this be marked as closed (won't fix)?

misc’s picture

misc commented
Status: Needs work » Closed (won't fix)

No contact address for the applicant, and marked as need work for 22 weeks. I'm closing this, @handrashekhar_srijan, if this is wrong, please reopen.