We recently updated PHP on our development server to version 5.3.6. It's now throwing notices for lines 5, 6 and 7 in uc_sagepayserver.module. This is because the three constants defined on this line are named by assumption rather than strings.
Not sure if this just different settings our side or a change in PHP; I couldn't see it mentioned in PHP's changelog. Regardless, I don't see why these constants' names are not defined as strings.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 1162364-sagepay-constants.patch | 1.05 KB | longwave |
Comments
Comment #1
longwavePatch attached.
Comment #2
longwaveMarked #1253206: Incorrect coding style causes PHP warnings and breaks admin_theme setting as duplicate
Comment #3
leo pitt commentedThanks - I have added this patch to the dev version, please try it out.
Comment #4
leo pitt commentedFixed in 6.x-1.5