We recently updated PHP on our development server to version 5.3.6. It's now throwing notices for lines 5, 6 and 7 in uc_sagepayserver.module. This is because the three constants defined on this line are named by assumption rather than strings.

Not sure if this just different settings our side or a change in PHP; I couldn't see it mentioned in PHP's changelog. Regardless, I don't see why these constants' names are not defined as strings.

CommentFileSizeAuthor
#1 1162364-sagepay-constants.patch1.05 KBlongwave

Comments

longwave’s picture

Status: Active » Needs review
StatusFileSize
new1.05 KB

Patch attached.

longwave’s picture

leo pitt’s picture

Assigned: Unassigned » leo pitt

Thanks - I have added this patch to the dev version, please try it out.

leo pitt’s picture

Status: Needs review » Fixed

Fixed in 6.x-1.5

Automatically closed -- issue fixed for 2 weeks with no activity.