Seems like I wrote this piece of code before I understood what 5.0's node_get_types('names') actually returns (an associative array like with the content type's machine-readable name as key and the user-visible name as value). As a consequence, the update/uninstall routine in nodefamily.install uses the user-visible name, which is wrong.

The following fix is based solely on theoretical conclusions and is completely untested. I'm too tired today to still test it out, but it should really be correct.

CommentFileSizeAuthor
nodefamily_fix_nodegettypes.patch1.05 KBjpetso

Comments

jpetso’s picture

jpetso commented
Status: Needs review » Reviewed & tested by the community

Tested, works.

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Reviewed & tested by the community » Fixed

ah sry, I forgot to close this one - I've already committed it. thanks :)

jpetso’s picture

jpetso commented

Oh. Er, I guess it's time to subscribe to a few more commit RSS feeds :)

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)