AJAX submissions try to validate other form fields: "An illegal choice has been detected." [#1162712]

Problem/Motivation

AJAX form submissions seem to fail validation for other fields in the form. Examples:
- uploading files to filefields
- adding values to multiple-value fields

Sample steps to reproduce

Create a new content type with a List (text) field, check/box radio button widget, allowed values Y and N, and make it required.
Leave default value empty.
Add a Filefield, allow these extensions: doc, docx, pdf, xls, xlsx, txt, and leave all other settings set to default (not required, public files, etc.).
Allow these extensions: doc, docx, pdf, xls, xlsx, txt..
Create content of the new type.
Leave the List (text) field blank
Upload an XLS file to the Filefield

Result:

Proposed resolution

Remaining tasks

User interface changes

API changes

Original report by gipsyx

All my file fields get an error when I try uploading files. I tried it on different content types, with different allowed extensions.

The error log says it's a form error, the message "Illegal choice in Type element."

The file fields where working fine until today, the only difference I could imagine was that I did some automatic updates, but I can't find a log of updated modules.

I don't know exactly what informations you need to fix this, please let me know if you need to know something else.

Comment	File	Size	Author
#9	Screenshot.png	37.04 KB	peezy
	Capture d’écran 2011-05-19 à 18.05.16.png	43.34 KB	Anonymous (not verified)

Comments

Comment #1

roam2345 commented 20 May 2011 at 09:52

Can we see the file field settings you used?

Comment #2

Anonymous (not verified) commented 20 May 2011 at 10:05

This is the file field export from Features. Does that help?

// Exported field: 'node-teaser_big-field_teaser_swf2'
  $fields['node-teaser_big-field_teaser_swf2'] = array(
    'field_config' => array(
      'active' => '1',
      'cardinality' => '1',
      'deleted' => '0',
      'entity_types' => array(),
      'field_name' => 'field_teaser_swf2',
      'foreign keys' => array(
        'fid' => array(
          'columns' => array(
            'fid' => 'fid',
          ),
          'table' => 'file_managed',
        ),
      ),
      'global_block_settings' => '1',
      'indexes' => array(
        'fid' => array(
          0 => 'fid',
        ),
      ),
      'module' => 'file',
      'settings' => array(
        'display_default' => 0,
        'display_field' => 0,
        'uri_scheme' => 'public',
      ),
      'translatable' => '1',
      'type' => 'file',
    ),
    'field_instance' => array(
      'bundle' => 'teaser_big',
      'deleted' => '0',
      'description' => '',
      'display' => array(
        'cck_blocks' => array(
          'label' => 'above',
          'settings' => array(),
          'type' => 'hidden',
          'weight' => 0,
        ),
        'default' => array(
          'label' => 'above',
          'module' => 'file',
          'settings' => array(),
          'type' => 'file_default',
          'weight' => 5,
        ),
        'teaser' => array(
          'label' => 'above',
          'settings' => array(),
          'type' => 'hidden',
          'weight' => 0,
        ),
      ),
      'entity_type' => 'node',
      'field_name' => 'field_teaser_swf2',
      'label' => 'Swf File',
      'required' => 0,
      'settings' => array(
        'description_field' => 0,
        'file_directory' => '',
        'file_extensions' => 'txt swf',
        'max_filesize' => '',
        'user_register_form' => FALSE,
      ),
      'widget' => array(
        'active' => 1,
        'module' => 'file',
        'settings' => array(
          'insert' => 0,
          'insert_class' => '',
          'insert_default' => 'auto',
          'insert_styles' => array(
            'auto' => 'auto',
            'image' => 0,
            'image_full_width' => 0,
            'image_half_width' => 0,
            'image_large' => 0,
            'image_medium' => 0,
            'image_newsletter_preview' => 0,
            'image_thumbnail' => 0,
            'image_tiny' => 0,
            'image_watch_detail' => 0,
            'image_watch_detail_thumbnail' => 0,
            'image_watch_overview_small' => 0,
            'link' => 0,
          ),
          'insert_width' => '',
          'progress_indicator' => 'throbber',
        ),
        'type' => 'file_generic',
        'weight' => '7',
      ),
    ),
  );

Comment #3

sun

German

Karlsruhe

commented 8 June 2011 at 00:51

Component:	forms system	» file.module
Category:	bug	» support
Priority:	Major	» Normal
Status:	Active	» Postponed (maintainer needs more info)

If this is really a bug in core, then we need clear steps to reproduce this bug in core (without contrib modules).

Comment #4

Wappie08 commented 18 August 2011 at 13:08

Component:	file.module	» forms system
Category:	support	» bug
Priority:	Normal	» Major
Status:	Postponed (maintainer needs more info)	» Active

Hello Sun, I just reproduced this error, hopefully this is reproducable on a clean install (mine was not clean).

The bug is quite nifty:

- set a integer list field with some keys + values and set the field to required. Then either set the default value to N/A or do not touch the field at all.
- Then put an imagefield of filefield in the form and it gives an error when trying to upload an image/file before selecting an option on the required integer list.

I also had some form_alter functions which produced errors when uploading files, I figured out that putting all form_alter functions inside a if ($form_state['executed'] == FALSE) {} prevented all errors.

Greetings Wappie

Comment #5

dawehner

German

commented 24 August 2011 at 17:40

I tryed to reproduce the issue by

adding a list-integer field with 0|a,1|b... with default to none
adding an image field

Then creating a node of this new type, touching nothing and upload a single image without changing the list-integer field.
And it worked fine without any kind of validation errors. The version used is the current git checkout of 7.x

Comment #6

xjm

she/her

English

commented 24 August 2011 at 23:54

Version:	7.0	» 7.x-dev
Status:	Active	» Closed (cannot reproduce)

I was also unable to reproduce this bug using a current checkout of core and following exactly the steps provided in #4. It may already have been resolved by another issue if it was indeed a bug in 7.0. Otherwise, it may be related to contrib or custom code. Reopen if you can reproduce using 7.x-dev or 8.x-dev, and post exact steps to reproduce starting from installation. If the error only occurs after an upgrade from 6.x, then we'll want steps to reproduce from the D6 install if at all possible.

Comment #7

peezy commented 15 November 2011 at 15:37

Status:

Closed (cannot reproduce)

» Active

I was able to reproduced the illegal choice error on 7.10-dev and 7-9 by doing this:

Create a new content type with a List (text) field, check/box radio button widget, allowed values Y and N, and make it required.
Leave default value empty.
Add a Filefield, allow these extensions: doc, docx, pdf, xls, xlsx, txt, and leave all other settings set to default (not required, public files, etc.).
Allow these extensions: doc, docx, pdf, xls, xlsx, txt..
Create content of the new type.
Leave the List (text) field blank
Upload an XLS file to the Filefield

The log reports the illegal choice in the List field.

Comment #8

xjm

she/her

English

commented 15 November 2011 at 15:42

#7 doesn't sound to me to be related to the filefield? You're making the list field required and then submitting no value.

Comment #9

peezy commented 15 November 2011 at 17:07

Status	File	Size
new	Screenshot.png	37.04 KB

Thanks for replying so quickly! I'll gladly post this elsewhere, if you wish.

So that you know, the error occurs only when I upload a file and only with the Radio Buttons/Checkbox widget (so, I'm not actually saving the node). When I change the text to a select list, I get the expected behavior (no error on upload). Also, the error renders in the Filefield area and not at the top of the page (please see attached screenshot).

Comment #10

xjm

she/her

English

commented 15 November 2011 at 18:03

Ahh. So it sounds like the AJAX submission is doing validation on the rest of the form, perhaps?

Comment #11

xjm

she/her

English

commented 15 November 2011 at 18:16

Title:	Unable to upload files with File Field. Error "An illegal choice has been detected. Please contact the site administrator."	» AJAX callbacks try to validate other form fields: "An illegal choice has been detected."
Version:	7.x-dev	» 8.x-dev

This is probably the same bug as:
#1120716: Clicking 'Add Another Item' causes 'An illegal choice has been detected error'
#1305694: Text field "Add another item" button validates unrelated fields, throws errors