Unified login shows wrong form on validation errors

The patch in #1 fixes this bug for me and preserves the destination. Thank you very much.

Re: #1

Go to user/register
Click Create new account
The destination is set to user/register

The same issue occurs at user/login with the destination set to user/login.

An updated patch is attached, but could this be handled in JavaScript instead?

EDIT: Don't use the attached patch.

patch no longer applies.

Patch rerolled against master. Nothing else changed. Setting to rtbc.

i don't think i want the destination handling in there, what's the use case? #1172652: Show unified login on Access Denied handles the problem for 403 and preserves destination.

Hi there,
is anything happening here? I have the opposite happening to the initial post.
Issue is the same though, it's not returning to the form that was submitted.

Eg.

Create new account with non-matching passwords.
Form fails validation returning to login form with password field highlighted.
User needs to click the 'create new account' button to get back to the correct form and see highlighted fields.

Patch in #8 doesn't work when the form is rendered on 403 pages.
There's no need to involve destination handling whatsoever.
The active form is set with javascript, so the fix is wholly javascript.

fixed trailing whitespace

The patch in #12 works except if a user goes to /user/register, clicks on the log in tab, and doesn't pass the login validation - in that situation they are still redirected to the registration form instead of the failed login form.

The patch attached adds a check on the user form for validation as well using the same method. I made the comment above the check a bit more generic as well to describe both checks.

Have tested the patch from #13 and confirm it fixes the issue. Could do with another confirmation before committing.

#13 seems to work for me, but I didn't test it thoroughly.

#13 also works for me

#13 also work for me. I tried many cases, it seems it is working for all.

So marked as reviewed & tested by the community - just need a project maintainer to integrate the patch.

#13 works for me. Can get this integrated into the module?

#13 works for me too. Thanks for the patch. +1 for commit :-)

#13 works for me too. Thanks for the patch. +1 for commit :-)

@Ryan Weal: Tabs lost after ajax submit is another matter. Check this out: https://drupal.org/node/1342262.

Applied patch from comment #13 to the latest 7.x-1.x-dev. This resolved the problem. Many thanks. RTBC++

#13 applies to 7.x-1.x-dev. RTBC++

(from 2 years ago!!!) What's stopping this from being committed?

I reached out to @Stevecowie the maintainer, he seems busy and was open to getting assistance in maintaining LT. However, I have not heard back from him since. So it seems this module isn't being maintained until he grants someone else access to do so. I have offered, but haven't heard back.

#13 works. Thanks a lot :)