Sign up for entering sports competitions online.

End user will

  1. Enter participant details
  2. see a summary
  3. pay
  4. get a confirmation/reciept.

Event organizer will be able to extract entry list.

The modules is designed to be extremely simple to use for endusers. It integrates with 42 Laps - a sports timing solution using RFID chips.

The module will be used for signing up to Salomon Trail Tour Denmark.

There are a lot of signup modules as well as sports event modules around but I have not found any module that does this really well.

In Denmark we have a "Dankort": by for the most used payment card. To use this card I have integrated the Quickpay module. This module is not available in a fully-working D7 version yet. I have got the module in a non-stable version from the maintainer. I've checked it in to the repository because it is needed to do the Dankort payment. I will remove it as soon as the D7 port of Quickpay is ready.

My plan is to integrate other payment providers, especially PayPal later.

Sandbox page:
http://drupal.org/sandbox/bjaxelsen/1138094

Comments

bjaxelsen’s picture

bjaxelsen commented
Priority: Normal » Major
jordojuice’s picture

jordojuice commented
Priority: Major » Normal

Sorry, but all project applications have the same priority. It's understandable that you might feel your application is being overlooked. The queue is just way backed up, but the reviewers are working hard to ensure quality and security for projects hosted on drupal.org.

bjaxelsen’s picture

bjaxelsen commented

Ok I understand. I was only trying to draw some attention to my new project to get it online.

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
Priority: Normal » Critical

Marking as critical as per http://drupal.org/node/894256
Sorry for the long wait.

wulff’s picture

wulff commented
Status: Needs review » Needs work

Completed initial review:

  • Checked the project for non-GPL files. None found.
  • Searched the "event" category for similar modules. None found. (A similar feature has been discussed in #219537: Sign up group to an event for Drupal 6, but nothing has happened, AFAICT.)
  • A quick review of the module file reveals good understanding of the Drupal APIs.
  • No security review has been performed.
  • Coder reports 2 critical warnings, 30 normal warnings, 50 minor warnings. These should be fixed.
  • The module is fairly well-documented, but a README.txt file describing how to setup the module would be of great help.
wulff’s picture

wulff commented

Also, in addition to removing the Quickpay module, the translations folder should be removed and the existing translations imported on l.d.o.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Priority: Critical » Normal
Issue tags: +PAreview: security 
echo '<html><body><p>' . str_replace("\n", '<br />', variable_get('sport_signup_terms', t('No terms has been configured yet.'))) . '</p></body></html>';

The use of echo and then a die is not very Drupalish. I'm not sure where this is used but maybe you could switch to using JSON to send the data with drupal_json?

This would be a security vulnerability because an admin of the module could insert XSS into the signup terms except for the fact that setting that variable requires "administer site configuration." I suggest using a "filter_xss_admin" around the sport_signup_terms all the same. The same seems to be true for other variables like $currency = variable_get('sport_signup_currency_abbreviation', 'kr.');

The sport_signup_42lapsdownload function loads a list of nodes without checking they are published or that the current user has access to them (node_access). Hopefully the view has those filters?

bjaxelsen’s picture

bjaxelsen commented
Title: Sport signup » Review improvements done
Status: Needs work » Needs review

Thanks wulff and greggles :-)

I have taken care of all of your suggestions. Just one thing remains: I am not sure about moving the translations to localize.drupal.org. It seems to me that I cannot upload them to the project before the project is accepted on drupal.org. Please correct me if I am wrong.

bjaxelsen’s picture

bjaxelsen commented
Title: Review improvements done » Sport signup module
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work

* git release branch is missing, see http://drupal.org/node/1015226
* README.txt is missing
* sport_signup_menu(): hook doc block missing
* "Implementation of hook_theme()." should be "Implements hook_theme()." Also elsewhere.
* variable_get() issue from #7 is not addressed in theme_sport_signup_summary()
* The module file is pretty big - have you considered moving the page and form callbacks to an include file?

misc’s picture

misc commented

bjaxelsen has been contacted to ask if the application is abandoned.

After ten weeks with a status of needs work: the applicant may be contacted by a reviewer to determine whether the application was indeed abandoned. The action taken by the reviewer should be documented in the project application issue.

http://drupal.org/node/894256

bjaxelsen’s picture

bjaxelsen commented
Status: Needs work » Needs review

Application is still active.

Module is used for signing up for 12 running events in Denmark, Europe:
http://signup.salomontrailtour.dk/

Review feedback should be fixed by now.

misc’s picture

misc commented

Hi,

Did an automatic review and you have some formatting issues to take care about:
http://ventral.org/pareview/httpgitdrupalorgsandboxbjaxelsen1138094git

If you have questions about the errors and warnings, please ask.

bjaxelsen’s picture

bjaxelsen commented

@MiSc

Module complies to Devel module automated review. In addition I have taken care of some of the issues in the review you link to.

A few notes:
- It is not an error that the module registers functions on behalf of other modules (Quickpay module)
- The module reuses various, well-working code snippets (JS form validation, extra server-side email validation, Mailchimp integration code), these have not been changed.
- The module embeds auto-generated Features module code. This code works well and I do not want to go through it, though the review complains about it.

misc’s picture

misc commented

@bjaxelsen, I do not know what you mean with Devel module automated review, but you module should follow Drupal coding standards, and it does not now, please see the automated test PAReview.sh online, http://ventral.org/pareview/httpgitdrupalorgsandboxbjaxelsen1138094git.

I have not read your code in detail - but you can not just take functions from other modules and put in your own, that are going to brake your module or the others modules, you have to use to prefix to avoid this. Also you can not just include other scripts in your module, you should just provide a download link and maybe use libraries module.

As I see it, you also need to correct the code from Features. But that could be other opinions on that subject.
After some thinking, I changed my mind, if the code from Features has the wrong format, that should not be a issue for you.

jthorson’s picture

jthorson commented

bjaxelson,

Have you considered adding http://drupal.org/project/mailchimp as a dependency for your sport_signup_mailchip module, and then removing the mailchimp code from your project?

Consider the scenario where someone is already using the MailChimp module on their site, and they install your feature ... you could end up with 'Cannot re-declare class MCAPI' errors which take down the site.

jthorson’s picture

jthorson commented
Status: Needs review » Needs work
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue summary: View changes

Just fixed HTML markup of text