AdvAgg - Use the CDN module for images referenced in CSS aggregates.

Notes: When I have more *time*, I intend to replace the 'above' use of

$data = preg_replace('/url\(\s*[\'"]?\/?(.+?)[\'"]?\s*\)/i', 'url('.$baseURI.'/$1)', $data);

with:

$data = preg_replace_callback('/url\([\'"]?(?![a-z]+:|\/+)([^\'")]+)[\'"]?\)/i', '_drupal_build_css_path', $contents);
.....
.....
_drupal_build_css_path()
....
....

The older method of 'preg_replace' at the top of this was used to prove the function / idea - not perfect it.

Thanks Mike,

Simply stated, D6 advagg + D6 cdn modules leave Drupal referencing CSS image links [via CSS background: url()) as relative links to the root of the host (CDN or other).

So with the way it was, CSS image links refer back to the parent [host] - not the actual image asset path!

When using my CDN (edgecast), without my above 'base-url' hack to advagg, the CSS relative links attempted to query my CDN's root domain - rather than the actual [full] path.

Actual example: my Edgecast CDN paths are:

http://small.gdlcdn.com/802C5F/cdn1 	http://cdn1.peterbowey.com.au:80
http://small.gdlcdn.com/802C5F/cdn2 	http://cdn2.peterbowey.com.au:80
http://small.gdlcdn.com/802C5F/cdn3 	http://cdn3.peterbowey.com.au:80
http://small.gdlcdn.com/802C5F/cdn4 	http://cdn4.peterbowey.com.au:80

I do NOT elect to use CNAME mapping (via Edgecast CDN)

So when I used the 'untouched' D6 advagg + D6 cdn, the final CSS has relative url links back to http://small.gdlcdn.com, this is a simple domain link - and NOT a full [absolute] path to the actual CSS image asset. Hence, the 'untouched' advagg + cdn breaks all my relative CSS image links. That is normal for most Drupal CSS that I have yet seen.

My above 'addition' - via the standard D6 core method does not. Hence, I 'hacked' this logic into advagg, for it is currently responsible for the creation [re-writing] of CSS - not so with the CDN module.

Yes, I have allowed Wim Leers to be 'privy' to this too.

'Eh' #4 that mapping would point CDN assets as myself,so no! (?)
The mapping of all http://cdnx.peterbowey.com.au is the private [back-link] path that the commercial Edgecast CDN pulls new aggregates from (via public web links thru small.gdlcdn.com/802C5F/cdnx)...

Need more coffee :)

#5 Nice being 'rare + one of'...case!

Are you sure on this? The only difference in my use of the commercial Edgecast CDN is dropping the use of CNAMES to get a domain - instead of my chosen domain + path...

Hmmm... coffee helped!

I see that you are suggesting the use a prefix' relative path to the CDN domain [use].
Hence, I would use:

if (file_exists('sites/all/modules/cdn/cdn.module')) {         // if Drupal Module CDN exists
  $my_cdn_css_url = '/802C5F/cdn1';     // get base url to add to CSS images
  $my_cdn_mapping = $my_cdn_css_url . '|.css'."\n";
  $my_cdn_mapping .= '/802C5F/cdn2|.js'."\n";
  $my_cdn_mapping .= '/802C5F/cdn3|.jpg .png .gif .ico'."\n";
  $my_cdn_mapping .= '/802C5F/cdn4|.pdf'."\n";
  $conf['cdn_basic_mapping'] = $my_cdn_mapping;
  $conf['my_cdn_css_base_url'] = $my_cdn_css_url;
}

Does this new relative method 'satisfy' the CSS Embedded Images module?

#9 Is that stating I need such mapping (as above) to occur in the right code area of advagg?
IE: Do I need to 'hack' advagg to do catch correct event chain..

Thanks Mike,

#11 makes sense light of where to 'hook' my code needs; I use the hook_advagg_css_alter within a new module with +weight (=bingo).

The rest of our 'cdn references /data chat' is likely 'not of important context' - not without a long open debate :)

So we will ignore that part' - for a bit :)

Refer #11
I took the 'lazy code path' and moved my previous advagg 'hack'

      if ($type == 'css') {
        $data = advagg_build_css_bundle($files);
      }
      elseif ($type == 'js') {
        $data = advagg_build_js_bundle($files);
      }

      // Invoke hook_advagg_js_alter() or hook_advagg_css_alter to give
      // installed modules a chance to modify the data in the bundle if
      // necessary.
      drupal_alter('advagg_' . $type, $data, $files, $bundle_md5);
+      if ($type == 'css') {
+        $baseURI = variable_get('my_cdn_css_base_url', '');
+        $data = preg_replace('/url\(\s*[\'"]?\/?(.+?)[\'"]?\s*\)/i', 'url('.$baseURI.'/$1)', $data);
      }
      $files_used = array_merge($files_used, $files);

      // If data is empty then do not include this bundle in the final output.
      if (empty($data) && !$force) {
        if (function_exists('lock_release')) {
          lock_release($lock_name);
        }
        continue;
      }

      // Create the advagg_$type/ within the files folder.

It now does the path 'prefix' after 'hook_advagg_css_alter'
Works OK