Download & Extend
Tables Filter Module » Issues

Update for Drupal 5.0

Posted by JHeffner on February 6, 2007 at 3:33pm
Project:Tables Filter Module
Version:6.x-1.x-dev
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

This is my first attempt to submit a patch. I'd welcome comments.

AttachmentSize
tables5.patch3.94 KB
Login or register to post comments

Comments

#1

Posted by preferred name on February 26, 2007 at 2:00am
Title:Tables filter 5 compatibilty» Valid XHTML 1.0 Strict!

search for

before the two of them.
search for

and add

after it

#2

Posted by preferred name on February 26, 2007 at 2:05am

opps...

in the tables.module file...

search for <table and add </p> before the two of them.
search for </table> and add <p> after it

#3

Posted by leafish_paul on March 5, 2007 at 8:59pm
Title:Valid XHTML 1.0 Strict!» Update for Drupal 5.0

Please don't change the issue title - it makes threads like this harder to find.

I'm just about to test this filter out in Drupal 5, and will try the patch. Many thanks, will report back soon.

#4

Posted by leafish_paul on March 5, 2007 at 9:13pm

First up, the .info file. Had to attach it with a .txt extension, sorry. Updated patch on the way.

AttachmentSize
tables.info_.txt 174 bytes

#5

Posted by leafish_paul on March 5, 2007 at 9:37pm

JHeffner's patch worked a treat in the most part - muchas gracias! Just two differences in mine (aside from some formatting):

  • Why remove 'admin/help#tables'? Admittedly, its not working properly for me yet but I've left it in for now.
  • Checking whether the '$css' variable is empty is pointless, as the variable contains the result of variable_get('tables_css', drupal_get_path('module','tables'). '/tables.css'), which always returns a value even if the variable is not in the database.

The only other quibble I have with this module is why the settings are on an admin page, rather than the usual input format configuration, but I guess thats another issue.

I have this patch and info file running on two dev sites, and it seems to be fine. Please review!

AttachmentSize
tables.module_drupal5.patch 4.47 KB

#6

Posted by TheFazz on March 11, 2007 at 3:14am

i applied the patch to the tables HEAD CVS, but it did not appear on the modules admin list. is this supposed to happen? if so, how do i activate it?

#7

Posted by leafish_paul on March 12, 2007 at 9:14pm

You'll need to add a file called tables.info in the /modules/tables/ folder - see comment #4.

#8

Posted by JHeffner on March 22, 2007 at 12:23am

Thanks.. I just grabbed your changes and it appears to be working fine.

#9

Posted by rickauer on September 14, 2007 at 1:49pm

I am using this patch on Drupal 5.2, too - thanks a lot! It seems to work perfectly.

Any plans on making it available within a 5.x-branch? I guess some people have difficulties in patching it together. There is also no real alternative to this module (tried tablemanager, but too complex and different goal).

Cheers,
Stephan

#10

Posted by ewilts on November 25, 2007 at 3:45pm

This appears to be working on Drupal 5.3. The only change I had to make was that with Drupal 4.6 (where I started), the input filters did not have to be rearranged (I have bbcode embedded within a table). With Drupal 5.3, the tables filter has to have a higher weight (i.e. heavier) than the bbcode filter. Once I figured that out, my complex table displays properly.

I started with the tables-4.7.x-1.x-dev.tar.gz release and applied the patch from comment #5 to it.

Thanks to Paul and Jason for their efforts!

#11

Posted by realityloop on February 29, 2008 at 1:17am

working on 5.7 / subscribe

Also is anyone able to add table, not to be confused with cell, alignment?

Edit:
Added Issue for table alignment: http://drupal.org/node/228218

#12

Posted by realityloop on May 20, 2010 at 10:46pm
Status:needs review» reviewed & tested by the community

#13

Posted by realityloop on December 31, 2010 at 8:33pm
Status:reviewed & tested by the community» fixed

dev release now downloadable, I will push a stable release if I get no feedback to indicate otherwise in a week or two

#14

Posted by System Message on January 14, 2011 at 8:40pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.