The extra values are currently sorted using a straight string comparison. This means that beta10 will not be the most recent release ahead of beta9. The changes break them out into separate fields so they can be sorted properly.

The following commits solve the sorting issue:
https://github.com/phase2/FeatureServer/commit/e6c4cfa3e5d29f0fee31e38a0...
https://github.com/phase2/FeatureServer/commit/c82f6c166711588458336e75a...

This following commits adds support for new git style version tags integrated with the extra sorting fields from above and adds unit test for all of it:
https://github.com/phase2/FeatureServer/commit/0ad9b318a5485e1548f89cd59...

Comments

eugenmayer’s picture

eugenmayer commented

Your implementation of the new git-tag parsing is much better. i will revert my commit and take yours. Perfect.

for the sort thing, i have implemented a very similar sort-algo in update_feed_api. Your implementation looks quiet huge, but it seems like you add some kind of new views-fields also, right?

eugenmayer’s picture

eugenmayer commented
Status: Active » Fixed

I just worked through you reporsitiory and you actually got any fixes we made in the blackice2999 repo with Dennis. i decided to remove the old master and take your one in, as it makes it a lot easier then merging those 3 pretty huge commits.

I added you as the maintainer of the project. Thanks for being that constructive! I will release 1.1 directly, just to be sure people test the latest codebase.

My idea would be to rapid-release the 1.x minors, to catch up with the current community patches. The plan would be having a stabel 2.0 release, also communicating this as the "next release" of the old fserver 1.0.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.