Having created a new gallery and triggered the image upload I receive this error multiple times (it looks like it is being triggered for each module that is being referenced during the page load).

Examples of the errors as they appear on page are (nb I have truncated my path for privacy reasons):

# warning: Missing argument 3 for notifications_team_form_alter() in .../sites/all/modules/notifications_team/notifications_team.module on line 609.
# warning: Missing argument 3 for content_profile_form_alter() in .../sites/all/modules/content_profile/content_profile.module on line 258.
# warning: Missing argument 3 for color_form_alter() in .../modules/color/color.module on line 32.
# warning: Missing argument 3 for comment_form_alter() in .../modules/comment/comment.module on line 489.
# warning: Missing argument 3 for menu_form_alter() in .../modules/menu/menu.module on line 360.
# warning: Missing argument 3 for node_form_alter() in .../modules/node/node.module on line 1849.
# warning: Missing argument 3 for path_form_alter() in .../modules/path/path.module on line 181.
# warning: Missing argument 3 for taxonomy_form_alter() in .../modules/taxonomy/taxonomy.module on line 504.
# warning: Missing argument 3 for update_form_alter() in .../modules/update/update.module on line 315.
# warning: Missing argument 3 for content_form_alter() in .../profiles/drupal_commons/modules/contrib/cck/content.module on line 438.
# warning: Missing argument 3 for content_copy_form_alter() in .../profiles/drupal_commons/modules/contrib/cck/modules/content_copy/content_copy.module on line 503.

The details in watchdog are all virtually the same (by this I mean that the location and referrer are the same for each reported error). Here is an example:

Location .../gallery_assist_upload/js
Referrer .../node/124/edit/ga_items
Message Missing argument 3 for vertical_tabs_form_alter() in .../profiles/drupal_commons/modules/contrib/vertical_tabs/vertical_tabs.module on line 37.

I'll post anymore info I come across as I try to track this through but I wanted to report it and see if anyone has the same thing, or any idea how to solve.

Cheers,
Crom

Comments

vogre’s picture

vogre commented

Line 1578 of gallery_assist.module looks like:

drupal_alter('form',$form_state, $form_id);

I think it should look like:

drupal_alter('form',$form, $form_state, $form_id);

Sorry, no time for providing patch, but it's obviously the source of warnings.

efarg’s picture

efarg commented

Yes!
I also saw the same problem on top in three different installations.
Code correction troubleshoots.
Thank you.

jcmc’s picture

jcmc commented

Hello,

hier the patch
http://drupalcode.org/project/gallery_assist.git/patch/6f18ff1

thanks and regards
Juan Carlos

jcmc’s picture

jcmc commented
Status: Active » Needs review

please remember to mark this thread to fixed if the issue is solved.

thanks and regards
Juan Carlos

efarg’s picture

efarg commented

Under PHP 5.3 the old error is there again.
I replaced the code:

  // Render the form for output.
  $form_id = 'gallery_assist_upload_js';
//  drupal_alter('form', $form, $form_state, $form_id);
  $data = array($form, $form_state, $form_id);
  drupal_alter('form', $data);
  $form_state = array('submitted' => FALSE);
  $form = form_builder('gallery_assist_upload_js', $form, $form_state);
  $output = theme('status_messages') . drupal_render($form);

to:

// Render the form for output.
  $form_id = 'gallery_assist_upload_js';
  drupal_alter($form, $form_state, $form_id);
  $form_state = array('submitted' => FALSE);
  $form = form_builder('gallery_assist_upload_js', $form, $form_state);
  $output = theme('status_messages') . drupal_render($form);

Now he does not appear any more.
It is not quite clear to myself yet, why. Who knows an explanation?