PHP notice on Devel Token Page of All Products

I have been working on the Ubercart tokens and I already found and fixed this problem locally. I'll be committing my changes to 7.x-3.x-dev in the next few days. If you're not using tokens you can just ignore those PHP notices. If you want to use product tokens you'll have to wait for the fix.

Re: #2. I believe I answered that in the issue queue for uc_custom_price.

Here is my patch to the Ubercart tokens system. Please try it and let me know if you still see errors. Note that with this patch, all product tokens start with product: instead of node:, so instead of using the [node:cost] token for the product cost you will need to use [product:cost].

Actually, use this patch. I accidentally left a couple of debugging statements in the previous one and forgot to rebase it against 7.x-3.x head.

+  $language_code = NULL;
+  if (isset($options['language'])) {
+    $language_code = $options['language']->language;
+  }
+  $sanitize = !empty($options['sanitize']);

This has been added to all token hooks, but $language_code never appears to be used, and uc_file_token_info() does not use $sanitize either.

These are git-style patches, you need to use "patch -p1" to apply them, which will ignore the a/ and b/ prefixes.

Looks like you're testing the first patch instead of the second, and the patch needs to be applied against 7.x-3.x-dev, not beta2.

Can some one take the time to link or explain how to apply this patch not sure why but i am more lost then Rebecca black in a recording studio on this.

@farnsworth: First, make sure you have a recent version of Ubercart 7.x-3.x installed. Then download the patch http://drupal.org/files/issues/tokens-overhaul_0.patch into your ubercart directory. Use the command patch -p1 < tokens-overhaul_0.patch to apply the patch.

The patch should work as is and provide the changed mentioned in #3. But as @longwave noticed in #6, there are still some new features I intend to add that haven't been finished yet.

Hmm doesn't seem to be working for me:

host-103-84:~ john$ cd /Users/john/Sites/kissi/ubercart/
host-103-84:ubercart john$ patch -p1 < tokens-overhaul_0.patch
patching file uc_cart/uc_cart.module
patching file uc_file/uc_file.tokens.inc
patching file uc_order/uc_order.rules_defaults.inc
patching file uc_order/uc_order.tokens.inc
patching file uc_product/uc_product.tokens.inc
Reversed (or previously applied) patch detected! Assume -R? [n] n
Apply anyway? [n]
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file uc_product/uc_product.tokens.inc.rej
patching file uc_roles/uc_roles.tokens.inc
patching file uc_stock/uc_stock.tokens.inc
patching file uc_store/uc_store.tokens.inc

errors still on site:

Notice: Undefined variable: object in uc_product_tokens() (line 96 of /home/johni/kissique.com/sites/all/modules/ubercart/uc_product/uc_product.tokens.inc).
Notice: Trying to get property of non-object in uc_product_tokens() (line 96 of /home/johni/kissique.com/sites/all/modules/ubercart/uc_product/uc_product.tokens.inc).

Also getting errors when I save configurations for this specific module, tweetbutton:

Notice: Undefined index: name in _token_token_tree_format_row() (line 107 of /home/johni/kissi.com/sites/all/modules/token/token.pages.inc).

Unsure where the error is

Committed attached patch.

Tagging to remind myself that I intend to write SimpleTest cases for Ubercart's token support.