Remove truncation from parent menu

Subscribing. I would like to know the reason too.

A rather annoying issue. In dropdowns with just a few nested menus titles quickly become unintelligible.

Also unsure what's the best way to override this -- ideas?

I have had this same problem. After searching for a solution, came across this post, found the function you mentioned and changed the value to 60 with no apparent side effects. Will update this post if I come across any problems.

If anyone can point me in the right direction as to if this function can be moved into the sites/modules or sites/theme folders and be rewritten as an override function, then that would be very much appreciated.

I think there is no other way then to copy the entire code into your own custom menu module and maintain it there. I did not find a other way of solving it. I moved these functions.

function menu_form_node_form_alter(&$form, $form_state) {}
function menu_parent_options($menus, $item, $type = '') {}
function _menu_get_options($menus, $available_menus, $item) {}
function _menu_parents_recurse($tree, $menu_name, $indent, &$options, $exclude, $depth_limit) {}

Hello steinmb,

how do you implement these functions in your custom module? You modify the names?
Can we use theses functions in the template.php file of the admin theme?
Finaly, have you found a more simplest solution for alter the number of characters?

Thanks for your help.

Really very annoying, 30 is too short, should be at least 60 or 72 by default.

Seems like Drupal 8 also has this limit:
https://api.drupal.org/api/drupal/core!lib!Drupal!Core!Menu!MenuParentFo...

It seems 60 characters is the decent limit, Patch attached changes the value to 60.

Retest requested to see if the patch is still good.

Verified and tested by applying the patch.It was applied successfully.It looks good to me.Can be moved to RTBC.

Steps to test -
1. Go to the admin site.
2. Go to admin/structure/menu/manage/admin/add?destination=/drupal9.1.x-dev/admin/structure/menu.
3. Create a menu link.
4. Again Go to admin/structure/menu/manage/admin/add?destination=/drupal9.1.x-dev/admin/structure/menu.
5. Verify the parent link field.

Before Patch -

After Patch -

Applied patch #7 and it works fine. I've added the word 'pneumonoultramicroscopicsilicovolcanoconiosis' as menu title and it comes normally as truncated in the parent link section.After applying this patch this problem is resolved.Adding screenshots below

before:

after patch:

The truncation was added in #151583: Menu - Fixes that make menu module work in D6 back in 2007. This was an omnibus patch fixing several issues in the menu system (while it was being rewritten), but where the 30 char truncation wasn't mentioned in the discussion.

Rather than increasing it to 60, I think we should just remove the truncation altogether.

Removing the truncation from parentSelectOptionsTreeWalk

Looks right to me.

Sorry folks, this needs an IS update. It should include, at least, the proposed resolution. And up to date before and after screenshots will help as well.

I don't know but does this need a test?

Applying IS template and tagging for tests

Re-roll for a Drupal 8.9.x.

Verified and tested patch#30 on the drupal 9.3.x-dev version. Patch applied successfully and looks good to me.

Applied patch #30 applied in drupal-9.3.x-dev applied successfully
After patch the width of select container auto set according to text

Verified and tested patch #30 on Drupal 9.5.x-dev. Patch applied successfully and looks good to me.
Testing steps:
1. Go to the admin site.
2. Go to admin/structure/menu/manage/main/add?destination=/d9.5/admin/structure/menu/manage/main.
3. Create a menu link.
4. Again Go to admin/structure/menu/manage/main/add?destination=/d9.5/admin/structure/menu/manage/main.
5. Verify the parent link field.
Testing Result:
1. After applying the patch the parent link is not truncated.
Can be move to RTBC

This is a nice wee improvement!

Just a few things to do before this is ready for a committer.

Following the process in Triage the Drupal core RTBC queue to review this issue.

3. The issue title is a statement of the problem, probably better as the fix. 'Remove truncation from parent menu'
4. The issue summary is clear and mostly accurate. The remaining tasks says this this needs tests and this is tagged for tests. There are no tests in the patch nor any discussion of whether a test is needed or not. The screenshots are out of date, they are from #19 and the patch has changed since then and so has the default admin theme.
5. Needs a decision on testing in order to pass the Testing gate.

Based on the above points setting back to NW.

Duplicate sets of screenshots have been added for that same patch, removing credit for #22, #34.

The work here is suitable as a novice task, adding tag.

Attached rerolled patch against drupal version 9.5x,,
Please review...

Verified and tested patch#30,Patch#39 and Patch#25 on the drupal 9.5.x-dev version. Patch applied successfully and looks good to me.We can move to RTBC.

Verified and tested patch#30,Patch#39 and Patch#25 on the drupal 9.5.x-dev version. Patch applied successfully and looks good to me.We can move to RTBC.

Patch #39 Applied successfully on Drupal 9.5.x.

#30 still applies to 9.5, there's no need for the reroll in #39 and the issue should not be changed from "needs work" to "needs review" unless the work requested has been completed. Even if it was a necessary reroll, there's no need to review it as it's effectively the same already-reviewed patch.

all that's left is to add a very simple parent item menu link title length longer than 30 characters assertion in the menu system tests for this

Patch is does not have any major changes so it still applies for the version 10.1.x as being said there would not been any requirement to reroll the patch. even i tried to apply the patch it applied successfully and work as expected.

Hi apply the patch#39 on drupal 10.1.x-dev it applied successfully and work as expected. there would not been any requirement to reroll the patch.
adding screenshot for the reference.
We can move to RTBC.
Thank You

I have created a patch against #39 drupal version 10.1.x. We need to remove truncation from parent menu not truncation limit increment according the query.
pls review ...

#51 Patch Applied on 10.1.x-dev and work as expected.

Issue tagged with "needs tests" and I find no tests in #51.

Attached a patch adding a functional test. I've put the test in MenuUiTest since it seemed like the appropriate place. The test won't pass if you don't apply the patch from #51

Please review!

Fixed failed CSpell test

Tested the above patch on 10.1.x

1. The issue summary is clear and steps to reproduce have been provided with screenshots
2. Was able to reproduce the issue
3. The patch applies cleanly and fixes the issue with menu item truncation
4. Did a code review and no issues were identified
5. Tests have been provided

The before after screenshots have been provided above and not much has changed since so avoiding these again. Looks good for RTBC

I read the Issue Summary. I do not see any difference between the before and after screen shots. I am missing something. If so, perhaps a comment to help the reviewer.

I applied that patch and tested by making an extremely long menu link. The result is not very friendly. I do like that in ends in an ellipsis. See the attached screenshot. Is removing truncation the best option here? I now think this needs a usability review. Adding tag.

+++ b/core/modules/menu_ui/tests/src/Functional/MenuUiTest.php
@@ -1141,4 +1141,22 @@ public function testMenuUiWithPendingRevisions() {
+  public function testMenuParentFormSelect() {

This test is only adding a link so it can be added to an existing test. That will allow us to not increase testing time and cost. I did not look closely but \Drupal\Tests\menu_ui\Functional\MenuUiTest::addMenuLink looks like a possible choice.

The before and after in the issue summary were referencing the same image. I updated the "after" to reference the image intended to be shown there. Note that the screenshot in #58 shows that there may be other "after" scenarios to consider beyond the ideal-scenario one presented in the IS.

Created MR from 56 and added a patch for composer use.
Applies to 11.x and 11.3.x.

The MR is doing its thing correctly with a passing test. As the issue is still tagged with it needs we to pass a usability gate I feel I should not set it to RTBC, however, I think we are done in here.

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.