I'm trying this out on a dev version of a site. I have thousands of revisions on this site that need to be cleaned up and removed, but the cron run is taking quite a long time. It looks like the module currently runs a node_load() on each and every revision that is being deleted and an individual database DELETE query on each. I wonder if there's any way we could speed up this process so that an initial cleanup of a large site wouldn't result in such a huge single initial cron run. Possibly it could be chunked out and done in pieces until the cleanup is complete... more like the build in Drupal Search module builds its index.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | revision_deletion_6.x_1.0_rc2_cron_limit_explanation.patch | 962 bytes | attheshow |
Comments
Comment #1
attheshow commentedOk, after further analysis of the code, it looks like whatever the administrator sets the "Number of Revisions per Page" setting to will be used during cron runs. So if the admin chooses "100" per page, not only does that show 100 revisions per page on the listing page, but also limits the cron run such that it will only delete a maximum of 100 items. It's a little strange that this isn't broken out into a different setting in the .admin.inc file.
Comment #2
attheshow commentedI've attached a patch for the admin form that explains that the limit will also be used by the module to control the number of revisions that are deleted on cron runs. Hopefully this will help other admins to understand this since it isn't obvious. (Patch attached to this issue.)
Comment #3
attheshow commentedAdjusting title of issue to match previous patch.
Comment #4
shaneonabike commented+1 this wasn't clear I thought the items per page referred to if you enabled this module to take over the revisions page.
Comment #5
danepowell commentedI agree an explanation is needed. I also think the explanation should point out the massive memory requirements, so this needs to be set reasonably (~1000 revision max).
I opened a separate related issue: #2091159: Reduce memory requirement, allow more frequent deletions
Comment #6
adriancid