review and update test suite

Yep - there isn't but it is being worked on actively by the qa.drupal.org team. What we can do is add 'dependencies' => array('workbench') to the moderation tests' getInfo() functions. This will prevent the tests from running on qa.drupal.org, and report back '0 fails' but also '0 passes' but still a green. It will allow us to test if patches apply to the current code base or not.

+++ b/tests/workbench_moderation.testundefined
@@ -9,8 +9,9 @@ class WorkbenchModerationTestCase extends DrupalWebTestCase {
+  function setUp($modules = array()) {

Changing the parameters for one setUp function without changing anything that depends on it as well will cause a PHP strict notice.

Looks good initially - will test.

+++ b/tests/workbench_moderation.testundefined
@@ -111,15 +112,14 @@ class WorkbenchModerationDraftTabTestCase extends WorkbenchModerationTestCase {
-  function setUp() {
-    parent::setUp();
-
-    // Workbench is now required for the mini moderation form.
-    module_enable(array('workbench'));
-
+  function setUp($modules = array()) {
+    parent::setUp(array('workbench'));
     $this->drupalLogin($this->moderator_user);

This should do an $modules[] = 'workbench';

+++ b/tests/workbench_moderation.testundefined
@@ -111,15 +112,14 @@ class WorkbenchModerationDraftTabTestCase extends WorkbenchModerationTestCase {
@@ -182,7 +182,7 @@ class WorkbenchModerationPublishFromNodeFormTestCase extends WorkbenchModeration

@@ -182,7 +182,7 @@ class WorkbenchModerationPublishFromNodeFormTestCase extends WorkbenchModeration
     );
   }
 
-  function setUp() {
+  function setUp($modules = array()) {
     parent::setUp();
     $this->drupalLogin($this->admin_user);
   }
@@ -222,7 +222,7 @@ class WorkbenchModerationUnpublishTestCase extends WorkbenchModerationTestCase {

@@ -222,7 +222,7 @@ class WorkbenchModerationUnpublishTestCase extends WorkbenchModerationTestCase {
     );
   }
 
-  function setUp() {
+  function setUp($modules = array()) {
     parent::setUp();
     $this->drupalLogin($this->admin_user);

These setUp functions should probably pass $modules into parent::setUp().

If this passes tests locally this looks good to me.