Notice: Constant USERPOINTS_INVITE_REGISTER_INVITER already defined [#1166590]

Comment	File	Size	Author
#6	userpoints_contrib-1166590.patch	759 bytes	gilgabar

Comment #1

dave reid

he/him

English

Nebraska USA

commented 23 May 2011 at 22:57

Project:	Token	» User Points Contributed modules
Version:	6.x-1.16	» 6.x-1.0-beta1

The error message is coming from userpoints_contrib, not token module. Please confirm which version of userpoints_contrib you are using (6.x-1.0-beta1 or 6.x-1.x-dev).

Log in or register to post comments

Comment #2

venusrising commented 23 May 2011 at 23:51

Hey Dave-
Thanks for the reply. Using User Points Contributed modules 6.x-1.0-beta1

Log in or register to post comments

Comment #3

venusrising commented 27 May 2011 at 08:32

When trying to update another module this error now appears again.

Log in or register to post comments

Comment #4

venusrising commented 1 June 2011 at 01:17

This error appears again on module update it is generating after module updates. Can someone please give me an idea of where to look, I have no idea what is causing this.
Notice: Constant USERPOINTS_INVITE_REGISTER_INVITER already defined in /home/oursite/html/sites/all/modules/userpoints_contrib/userpoints_invite/userpoints_invite.install on line 5

Notice: Constant USERPOINTS_INVITE_REGISTER_INVITEE already defined in /home/oursite/html/sites/all/modules/userpoints_contrib/userpoints_invite/userpoints_invite.install on line 6
Can someone please advise

Log in or register to post comments

Comment #5

venusrising commented 1 June 2011 at 22:05

This error is now popping up when I try to clear the cache form time to time.

Log in or register to post comments

Comment #6

gilgabar commented 17 June 2011 at 03:10

Version:	6.x-1.0-beta1	» 6.x-1.x-dev
Status:	Active	» Needs review

Status	File	Size
new	userpoints_contrib-1166590.patch	759 bytes

I'm seeing this too. The error message describes the problem fairly well. A couple of constants are defined twice. Once in userpoints_invite.module and once in userpoints_invite.install. It seems like a pretty gratuitous use of constants anyway, so the best solution might be to not use constants for variable names at all. A simpler solution for now is to just remove the constants from the install file and make the install file load the module file when it runs the function that requires the constants. A patch is attached.

Log in or register to post comments

Comment #7

venusrising commented 17 June 2011 at 06:14

@gilgabar I am not sure how it is under Dev we are actually using 6.x-1.0-beta1 as per #2. Will this work with that too? Is this safe for production as it is our production site that we are seeing this on. Shows up intermittently and on cron run. We do not want this to cause any conflicts with user points and other tie ins like Userpoint badges etc so wanted to clarify.
Thanks for the help!

Log in or register to post comments

Comment #8

gilgabar commented 17 June 2011 at 06:58

It isn't any different on the dev version. It should be fine on a production site. That particular piece of code should only ever be run once and then ignored anyway as it is an update. You have most likely already run that update, so it should be of little concern.

Log in or register to post comments

Comment #9

venusrising commented 17 June 2011 at 23:32

@gilgabar Thanks for the help. I will get it applied and report back.

Log in or register to post comments

Comment #10

berdir

German

Switzerland

commented 18 June 2011 at 14:21

I agree that constants shouldn't be used for this, we tried to remove most of them during the port to 7.x.

Will commit this as soon as someone confirms that this works correctly.

Log in or register to post comments

Comment #11

venusrising commented 25 June 2011 at 04:02

Patched to production site and updated, all seems well so far. Ran cron too and do not see the error any longer but not to sure how to re-create it as it did happen intermittently.

Log in or register to post comments

Comment #12

berdir

German

Switzerland

commented 6 July 2011 at 22:10

Status:

Needs review

» Fixed

Remove the whole file, that is a 5.x update function, there is no need for it to exist in 6.x-1.x and that was the only function in that file.

Log in or register to post comments

Comment #13

venusrising commented 8 July 2011 at 07:23

@Berdir I applied patch #6 are you saying this issue should not be handled that way, can you please confirm when you say remove file, can you clarify which file.
Thanks all