When I "Report as spam or unsolicited advertising" and delete a comment, the entry in the site log has an empty session id:

Type      mollom
Date      Tuesday, May 24, 2011 - 10:47am
User      MikeKeran
Location  http://<...snip...>
Referrer  http://<...snip...>
Message   Reported 'spam' for session id ''.
Severity  notice
Hostname  <...snip...>
Operations
CommentFileSizeAuthor
#6 mollom.feedback-empty-session.6.patch1.96 KBsun
#2 mollom.feedback-empty-session.2.patch1.91 KBsun
#1 mollom.feedback-empty-session.1.patch1.28 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: 6.x-1.15 » 7.x-1.x-dev
Status: Active » Needs review
Issue tags: +Needs backport to D6
StatusFileSize
new mollom.feedback-empty-session.1.patch1.28 KB

Attached patch fixes the issue by not attempting to send feedback for entities that do not have a session_id.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new mollom.feedback-empty-session.2.patch1.91 KB

Slightly cleaner, checking for a non-empty session_id in the calling code already.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Title: Watchdog entry has empty session id » Needless attempts to send feedback for unknown sessions
Version: 7.x-1.x-dev » 6.x-1.x-dev

Committed to master.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Issue tags: -Needs backport to D6

#2: mollom.feedback-empty-session.2.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs backport to D6

The last submitted patch, mollom.feedback-empty-session.2.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new mollom.feedback-empty-session.6.patch1.96 KB
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Fixed

Committed to 6.x-1.x.

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 0860e1e on master, fai6, 8.x-2.x, fbajs, actions by sun: 
    - #1167488 by sun: Fixed Needless attempts to send feedback for unknown...

  • Commit 0860e1e on master, fai6, 8.x-2.x, fbajs, actions by sun: 
    - #1167488 by sun: Fixed Needless attempts to send feedback for unknown...