The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.I've started porting the old spaces_og_nodeapi function over to the D7 equivalents. I'll upload a patch shortly, still needs quite a bit of work.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | spaces_og-1167884-10.patch | 20.54 KB | jhedstrom |
| #9 | spaces_og-1167884-09.patch | 16.6 KB | jhedstrom |
| #7 | spaces-nodeapi-1167884-07.patch | 13.79 KB | jhedstrom |
| #6 | spaces-nodeapi-1167884-06.patch | 13.27 KB | jhedstrom |
| #5 | spaces-nodeapi-1167884-05.patch | 13.31 KB | jhedstrom |
Comments
Comment #1
jhedstromThe work left to do involves figuring out the D7 OG replacement for og_is_omitted_type(), and moving the rest of the nodeapi functions that used that function over to the new versions.
Comment #2
jhedstromThis patch completes the transition from the old hook_nodeapi to the individual hooks, and replaces the og_is_omitted_type() function with a
variable_get('og_group_type_' . $node->type, 'omitted') != 'omitted').Comment #3
jhedstromUpdated to properly call og_is_group_type(), which now takes an entity type argument.
Comment #4
jhedstromMaking this more general, as keeping the tasks separately was getting annoying.
Comment #5
jhedstromThis version allows creating groups, and the purl prefix is also created. Needs quite a bit of work though. I've added TODOs on issues I've come across (most of these are due to there being no clear API docs for Organic Groups 6 to 7). The resultant group goes to a 403 unfortunately, but this looks to be related to deeper issues in the spaces upgrade.
Comment #6
jhedstromOops. That last patch had a few xdebug_breaks in it.
Comment #7
jhedstromLast one for today :) This comments out og_get_breadcrumb() which no longer exists in 7.x.
Comment #8
jide commentedsub.
Comment #9
jhedstromAdding some work around spaces_og.test.
Comment #10
jhedstromHere's an updated patch that has a few additional spaces_og tests passing.
Comment #11
webflo commentedHi thanks for you patches. I have done some patches too. My sandbox here: http://drupal.org/sandbox/webflo/1191114
Comment #12
Grayside commentedIt's awesome that you both are pushing forward on this, but I was hoping to pause the active development work for some architectural chatter. I would probably start a GDO post, but there's no clear place for one at this point.
I think it's important that before we put the effort to upgrade Spaces OG as it is, we take a moment and think about what Spaces OG should be. Right now it's a combination of Spaces Integration for OG, and "Enhanced UX for a Specific Use Case of OG". I'd like to see the aggressive attention Spaces OG gives to node privacy and OG access separated into a separate module. I think this would also concentrate and accelerate the core effort of creating the new Spaces OG.
I have other thoughts about Spaces in an entity-driven world that haven't gelled yet into actual opinions.
Comment #13
webflo commentedSounds good. I need a working version is a few weeks. I am open for architectural changes, e.g. Spaces OG should work for every entity because every entity can be a group. Atm Spaces OG is implemented for nodes only.
Comment #14
Grayside commentedI think that has to wait.
I'm in favor of separate the integration from the use case because I think it will accelerate development, and because the use case doesn't belong as part of the module. Adding proper treatment of entities would be a major delay.
Comment #15
NaX commentedMy suggestion would be for direct port now so people can start using D7 and then once that is stable a version 4 could be developed focusing on an entity driven system. An entity based spaces has the potential of simplify the code.
In theory a 7.3 and 7.4 could be developed in tandem with 7.3 providing a migration path from 6.x and 7.4 providing a migration path from 7.3.
Thats my two cents.
Comment #16
jhedstromI agree with an immediate port, if possible, and then a re-architecture for entity-based OG integration in a later major version of Spaces.
Comment #17
NaX commentedLooking at patches here and commits to Git I think we already have a possibly working dev release of spaces. A lot of the work for a stable 7.3 has already been done we just have to get it stable enough now for an alpha or beta release. So I think a stable (RC quality) 7.3 is very close. Once that is done a 7.4 re-write could be worked on but others can still use Spaces on 7.x projects.
@Grayside
I would also like to hear more about your thoughts on an Entity re-write. The one thing I am very interested in is the possibility of using presets in views. I looked at hacking together something for 6.x but I did not get very far. The things I am interested in is the possibility to controlling search priority by presets and filtering by presets. EG: Preset weights. If Presets were Entities this would be easy. The variable overrides would then just be settings per an Entity and I think that would work in a very similar way as it does now, but other fields would be available per a Preset EG: machine name, name, description and maybe others like weight which could be added by an add-on module. I also know that this was not the original intention of Development Seeds direction for this module as they wanted it to be more focused at being a light weight variables and context system with the ability of storing presets in code.
Where would be the correct places for discussions like this? A Spaces Group or Task/Issues? Just point me to the place you think would be best to discuss this I will gladly participate were I can.
Comment #18
Grayside commented@NaX Ideally we would have a GDO group. I haven't found the venue to discuss what to call such a group. I'm pretty close to just doing something.
Glad to hear Spaces has come along so far. I've only been judging by D.O's commit log and a couple issue queues, which make it feel a bit sluggish.
Comment #19
cweagans@Grayside, please create a new issue with your architectural ideas. I think that it's important to have a working D7 port of spaces_og, ASAP. Major architectural changes would be a good reason for a 4.0 release, don't you think?
Comment #20
Grayside commented@cweagans #1203046: Spaces 7.x-4.x Architecture
Comment #21
webankit commented+1
Comment #22
jhedstrom@webflo, here's my sandbox: http://drupal.org/sandbox/jhedstrom/1177232
Comment #23
karens commentedThe patch in #1182964: OG Spaces: Provide methode for og context negotiation is one additional piece that is necessary. I haven't tested the patch but it looks like it is generally the right way to go. This is the replacement for og_set_context(), you create a plugin that determines context and that plugin is called anytime og_context() is invoked to see what it can tell about what the context should be.
Once that plugin is added, you have to go to admin/config/group/context and enable the new plugin and decide how its weight should be set compared to other methods of determining context.
Comment #24
febbraro commentedHey everyone, sorry for the radio silence. Many reasons, but I'll leave it at that.
In any case, I spoke with webflo earlier and took his sandbox and made it the 7.x-3.x version. New branch to keep with the numbering. In any case, lets move all issues off of that branch and deal with them from there. Thanks for all of your interest, attention, and patches. Great to see it.