As per a conversation with @pwolanin on IRC, there might be instances where a searcher is indexing multiple entities, either Drupal or not. Therefore it would be beneficial for each adapter to be associated with multiple types in an array as opposed to confining them to a single type.

CommentFileSizeAuthor
#12 committers.jpg43.63 KBcpliakas
#10 facetapi-typo-in-legacy-support-code-1167974-10.patch456 bytesdas-peter
#7 facetapi-1167974-7.patch3.03 KBcpliakas

Comments

cpliakas’s picture

cpliakas commented

Note that the bundle dependency plugin has some assumptions surrounding the type that need to be broken.

cpliakas’s picture

cpliakas commented
Status: Active » Postponed
cpliakas’s picture

cpliakas commented
Category: feature » task
Priority: Normal » Major
Status: Postponed » Active

Marking as active. We need to maintain backwards compatibility for this change so that we don't have to synchronize releases with the other backends. This means that the adapter will have both "type" and "types" keys.

cpliakas’s picture

cpliakas commented
Issue tags: +7.x-1.0-beta4 blocker

Marking as a beta4 blocker.

cpliakas’s picture

cpliakas commented
Issue tags: +Backwards compatible API change

Adding new tag to track backwards compatible API changes. Legacy code should be removed when the module goes 1.0.

cpliakas’s picture

cpliakas commented
Issue tags: -7.x-1.0-beta4 blocker

Changed my mind. There are more important fixes that should be released ASAP.

cpliakas’s picture

cpliakas commented
Status: Active » Needs review
StatusFileSize
new facetapi-1167974-7.patch3.03 KB

First crack at resolving this. The known issue is that the bundle is not entity aware. We really need facets that contain bundles a way to identify themselves as such.

cpliakas’s picture

cpliakas commented
Issue tags: +D7 stable release blocker

Webchick says jump, I say "how high?". http://www.webchick.net/node/89

cpliakas’s picture

cpliakas commented
Status: Needs review » Fixed

Resolved in commit 9cc690e. Bundle issue posted at #1222754: Resolve assumptions in the "bundle" dependency plugin.

das-peter’s picture

das-peter commented
Status: Fixed » Needs review
StatusFileSize
new facetapi-typo-in-legacy-support-code-1167974-10.patch456 bytes

Just came across an issue while playing around with the facet_api <-> search_api integration.
The code for the legacy support of the type key deletes the whole info array.
Attached patch fixes this.

cpliakas’s picture

cpliakas commented
Status: Needs review » Reviewed & tested by the community

Oh boy. Great catch! Looks good to me.

cpliakas’s picture

cpliakas commented
Status: Reviewed & tested by the community » Fixed
StatusFileSize
new committers.jpg43.63 KB

Committed at 5be7a86.

Congrats on becoming the 5th committer to Facet API!

Thanks,
Chris

Automatically closed -- issue fixed for 2 weeks with no activity.