Non group member posting into a public forum - taxonomy failure [#1168000]

Noticed this bug is still present in your sandbox, which I am experimenting with adopting.

Linking here to
http://drupal.org/node/651672#comment-3573210

Fix is on line 309 of your og_forum.module in function og_forum_get_sql():

-  $return['where'] = "ogt.public > " . PRIVATE_BY_GROUP_OWNER;
+  $return['where'] = "ogt.public is NULL OR ogt.public > " . PRIVATE_BY_GROUP_OWNER;

Similar to the comment I've linked to above, but you've moved things around a bit. Nice clean ups btw. Much needed.

Submitting patch (based on your version of og_forum.module).

Comment	File	Size	Author
	og_forum.module-651672-53.patch	574 bytes	pro.methean

Comments

Comment #1

pro.methean commented 25 May 2011 at 04:30

As a possible issue to my patch above, one wonders why ogt.public is NULL in a case where we are posting a new forum topic to a group forum.

It is interesting to note that the above patch properly excludes private forums for non members in the case where the group has public and private forums. (We often have this use case: where a group has a Public Relations forum and a Private Discussion forum.)