After enabling an imported feature using fe_nodequeue I get the following error when accesing the features page or doing drush cc all:

Fatal error: Call to undefined function nodequeue_edit_queue_form_submit() in /path/to/drupal/sites/all/modules/contrib/features_extra/fe_nodequeue.module on line 276

The missing function is in nodequeue/includes/nodeque.admin.inc line 530.

I'm using nodequeue 6.x-2.10 and features_extra 6.x-1.x-dev.

CommentFileSizeAuthor
#9 fe_nodequeue-features_get_default_params_order-1168634.patch3.02 KBatouchard
#1 features_extra-1168634-1.patch470 bytessharpbites

Comments

sharpbites’s picture

sharpbites commented
StatusFileSize
new features_extra-1168634-1.patch470 bytes

Patch added

davad’s picture

davad commented
Status: Active » Reviewed & tested by the community

Patch works great.

burningdog’s picture

burningdog commented

+1 for inclusion - the patch solves the 'Fatal error' issue.

drupalninja99’s picture

drupalninja99 commented

Patch works for me too, can we get this patched into dev asap?

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Status: Reviewed & tested by the community » Fixed

Patch applied cleanly. Committed, pushed, attributed to elreperro. Thank you!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

atouchard’s picture

atouchard commented

there is an error in this commit 07443b0.
In fe_nodequeue_queue_features_revert() and fe_nodequeue_queue_features_rebuild(), the parameters of
$defaults = features_get_default($table, $module_name);
must be in this order
$defaults = features_get_default($module_name, $table);

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Status: Closed (fixed) » Needs work

Can someone else confirm this? The order of these parameters seems to keep switching in different patches, and I don't know which order is correct. New patch welcome; just explain what the change does. I'm not a Nodequeue user myself.

atouchard’s picture

atouchard commented
StatusFileSize
new fe_nodequeue-features_get_default_params_order-1168634.patch3.02 KB

I don't have seen these issues before to post #892754: Wrong order for features_get_default breaks everything and #879588: Wrong syntax order for features_get_default() breaks all Features Extra modules.
The answer is that the order of parameters of features_get_default() in features.export.inc has changed in features 6.x-1.0-beta9.
So, if you only use a prior version of "features", the patch below works with the latest dev version of feature_extra.

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Issue summary: View changes
Status: Needs work » Closed (outdated)

Drupal 6 is no longer supported. Closing.