[pgsql] location field in locales_source is the wrong field type., [#11689]

Comment	File	Size	Author
#7	locale-inc.patch	739 bytes	killes@www.drop.org

#4	pgsql_locales_fix_0.diff	2.64 KB	adrian

#3	pgsql_taxo_bug_0.diff	1.96 KB	adrian

	pgsql_locales_fix.diff	2.09 KB	adrian

Comment #1

killes@www.drop.org CreditAttribution: killes@www.drop.org commented 18 October 2004 at 16:39

Priority:

Critical

» Normal

The patch should not be neccessary becuase the location field is pruned to contain 128 chars. But - at least for pgsql- it doesn#t hurt either.

Log in or register to post comments

Comment #2

adrian CreditAttribution: adrian commented 18 October 2004 at 16:57

here is an updated patch, which fixes the problem with too many unique restraints on locales_target.

Log in or register to post comments

Comment #3

adrian CreditAttribution: adrian commented 18 October 2004 at 16:59

File	Size
pgsql_taxo_bug_0.diff	1.96 KB

err. here is the patch.

Log in or register to post comments

Comment #4

adrian CreditAttribution: adrian commented 18 October 2004 at 18:17

File	Size
pgsql_locales_fix_0.diff	2.64 KB

here is a corrected patch, it contained some cruft fromt he taxonomy patch i made earlier

Log in or register to post comments

Comment #5

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy commented 18 October 2004 at 19:53

Version:

4.5.0-rc

»

Killes, the 128 char check is improperly implemented (the length is checked before a new substring of unknown length is added), so that check needs to be fixed in the first place.

Log in or register to post comments

Comment #6

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy commented 18 October 2004 at 19:55

Killes, the 128 char check is improperly implemented (the length is checked before a new substring of unknown length is added), so that check needs to be fixed in the first place.

Log in or register to post comments

Comment #7

killes@www.drop.org CreditAttribution: killes@www.drop.org commented 13 March 2005 at 20:31

Component:	postgresql database	» locale.module
Assigned:	vertice@www.drop.org	» killes@www.drop.org

File	Size
locale-inc.patch	739 bytes

How about this?

Log in or register to post comments

Comment #8

Steven CreditAttribution: Steven commented 18 March 2005 at 09:06

The first patch was apparently applied to CVS already. But it seems that in the pgsql code, the temporary column "old_location" is not dropped?

Still, we should decide on this... either we:
- Remove the substring checking completely and change "location" to text in both pgsql and mysql.
or
- We go back to a 128-char location, change the db columns back, and implement killes' improved checker.

By the way killes, I think the strlen($comm) < 128 in the while() condition is unnecessary with your later check in place.