Attached a patch to print correctly all recipient type descriptions in the item_list.

CommentFileSizeAuthor
#7 description-item-list-1169440-1.patch536 bytespaolomainardi
#1 description-item-list-1169440-1.patch684 bytespaolomainardi

Comments

paolomainardi’s picture

paolomainardi commented
StatusFileSize
new description-item-list-1169440-1.patch684 bytes
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review

Thanks for working on this, remember to always set issues to needs review if you upload patches, then they will be automatically tested.

Status: Needs review » Needs work

The last submitted patch, description-item-list-1169440-1.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review

Looks like a backporting issue :)

Would be awesome to get a test for this, should be easy to extend the privatemsg_roles tests to verify that their description is shown.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work
berdir’s picture

berdir
Primary language German
Location Switzerland
commented 
index 058f93b..efd47f1 100644
--- a/sites/all/modules/contrib/privatemsg/privatemsg.pages.inc

The path is wrong, it needs to start inside the privatemsg folder.

With git, you can use the --relative option.

Powered by Dreditor.

paolomainardi’s picture

paolomainardi commented
Status: Needs review » Needs work
StatusFileSize
new description-item-list-1169440-1.patch536 bytes

Corrected patch

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Fixed

Wrote a test for this and commited it.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.