Port to Drupal 7

I ran KML 6.x-2.0-alpha1 through Coder Upgrade... first through the Coding Standards process, then Core API changes.

There are a few issues but it's actually kind of working!

So, a KML Feed Views display can been added, and fields defined properly.

When the display is loaded again, (in the Views UI,) though -- upon saving the View or upon switching to the display from another display -- the KML Content-Type headers are being injected, and my browser wants to download the views display UI (and thinks it's a KML file.)

Doing something simple and dumb like commenting out these lines in template_preprocess_views_view_kml() allows us to avoid this problem:

  //drupal_add_http_header('Content-Type', 'application/vnd.google-earth.kml+xml; charset=utf-8');
  //drupal_add_http_header("Content-Disposition: attachment; filename=$filename");

The attached patch makes [only] this change to the previous one.

Other errors are thrown, and when really downloading the file, the type is now discovered... but we can actually download our KML, and continue to use and edit the display Views.

Ah, this is better:

  if (empty($vars['view']->live_preview)) {
    drupal_add_http_header('Content-Type', 'application/vnd.google-earth.kml+xml; charset=utf-8');
    drupal_add_http_header("Content-Disposition: attachment; filename=$filename");
  }

(Views does it like this for the RSS Feed style plugin...)

Lots of other Warnings and Notices being thrown... I'm still poking.

This patch not only includes the change in #3, but a bunch of hacks to get rid of warnings and notices:

in template_preprocess_views_view_kml() :

+  $rows = '';
   foreach ($points as $point) {
     $rows .= theme('kml_placemark', array('point' => $point, 'points' => $points));
   }

in template_preprocess_kml_placemark() :

-  $vars['styleUrl'] = check_plain($vars['point']['styleUrl']);
+  $vars['styleUrl'] = isset($vars['point']['styleUrl']) ? check_plain($vars['point']['styleUrl']) : '';

in views_plugin_style_kml::option_definition() :

-      'default' => $this->filename,
+      'default' => isset($this->filename) ? $this->filename : '',

in views_plugin_style_kml::map_rows() :

-      if ($this->options['linestring']['enable']) {
+      if (isset($this->options['linestring']) && $this->options['linestring']['enable']) {

and added a mostly blank file, views/kml_style.theme.inc :

<?php
?>

tmcw: awesome; thanks!!

I was just getting annoyed at rolling full patches for tiny changes.

I've got a bit of learning to do here on the process, but I'd love to commit this (and tag as 7.x-1.x-dev?) if you're comfortable with that.

OK. 7.x-1.x pushed.

I'd appreciate if you let me know if I've done things properly...

From my initial clone, (even before doing anything) git has been complaining:

warning: refname 'HEAD' is ambiguous.

I see a HEAD tag in there (git tag -l)... is that normal?

I've made another small fix, and published 7.x-1.x as a dev release.

AlexisWilke: you can just delete the tag with "git tag -d HEAD". I think you might need to "git push --tags" after that.