Nginx http service runs hook_provision_nginx_vhost_config() and hook_provision_nginx_server_config() but extra configuration lines don't get inside the configs because of missing template variables.
I had to add this:

<?php print $extra_config; ?>
CommentFileSizeAuthor
#2 provision_nginx_extra_config_1170498.patch1.18 KBcrea

Comments

anarcat’s picture

anarcat commented

I would let omega8cc comment on that, but if you could provide a patch, that would be awesome.

crea’s picture

crea commented
Status: Active » Needs review
StatusFileSize
new provision_nginx_extra_config_1170498.patch1.18 KB

Sure

omega8cc’s picture

omega8cc commented
Status: Needs review » Reviewed & tested by the community

Well done.
Thanks for the patch!

anarcat’s picture

anarcat commented
Status: Reviewed & tested by the community » Fixed

awesome, thanks! pushed to 1.x and 2.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nicholas.alipaz’s picture

nicholas.alipaz commented
Version: 6.x-1.1 » 6.x-2.1
Issue summary: View changes
Status: Closed (fixed) » Needs work

I believe this may not actually be fixed in Provision 2.x. I have an nginx server that seems unaffected by the <?php print $extra_config; ?> in the two aforementioned files.

The locations of these differ from the patch from what I can tell. /var/aegir/.drush/provision/http/Provision/Config/Nginx/ for me.

omega8cc’s picture

omega8cc commented

Are you aware that since 2.x and introduction of Drush 5 and now Drush 6, you have to clear Drush own cache before any extra file will be really used/visible to Drush and thus Provision via this method?

omega8cc’s picture

omega8cc commented
Version: 6.x-2.1 » 6.x-1.1
Status: Needs work » Closed (fixed)

This particular issue has been fixed. Please open new issue if you experience problems.

nicholas.alipaz’s picture

nicholas.alipaz commented

Actually, false alarm, a drush cc drush fixed it. Sorry for the noise.