Commerce Payflow Pro

Please read the Full Project Permission Application page and follow the instructions. Specifically, I'd like you to speak more clearly to the first item:

A detailed description of what your project does, including how it is different from other, similar projects, if applicable.

You no longer have to include anything in files[] except files that contain classes that should be autoloaded (which does include the .test file)

 * @file
 * Ensures users have cURL enabled prior to installation.

Looks like that's supposed to be a function block, not a file block.

Nit: In D7 we use "Implements hook_..." not "Implementation of".

Please read the Coding Standards page and run Coder module on this.

I'm a little baffled why there's auth.net stuff all the way through the .module...

Kind of looks to me like this is a copy-and-paste module. I wish you'd use a module that you built from scratch for a full project application, but it's no big deal.

#2 contained quite a number of other things that needed to be fixed... I don't see any new commits. Putting to "needs work"

Looking...

You created a branch named 7.x-1.0 - that will cause you no end of pain. You'll want to rename it to 7.x-1.x. A *tag* for release would be called 7.x-1.0, not a branch. I think http://drupal.org/node/1066342 will give you the whole scoop.

You still have plenty of references to authorize.net

$ grep -ri auth.*net *
commerce_payflow_pro.module:    '#description' => t('Adjust to live transactions when you are ready to start processing real payments.') . '<br />' . t('Only specify a developer test account if you login to your account through https://test.authorize.net.'),
commerce_payflow_pro.module:    watchdog('commerce_payflow_pro', 'Authorize.Net AIM request to @url: !param', array('@url' => $url, '!param' => '<pre>' . check_plain(print_r($log_nvp, TRUE)) . '</pre>'), WATCHDOG_DEBUG);
includes/commerce_payflow_pro.admin.inc:    form_set_error('amount', t('You cannot capture more than you authorized through Authorize.Net.'));

Sad to say it, but if you're going to copy and paste this way, you have to at least clean up the results.

I guess this will be OK when you get this cleaned up.

OK, looks OK to me.

Yes, I'd delete that 1.0 tag (git tag -d 7.x-1.0; git push origin :7.x-1.0) as it will probably be some time before you're at 1.0

As long as nobody has a contrary opinion, someone will come along and promote your user account.

Hi markie,

Thanks for your contribution and welcome to the community of project contributors on drupal.org.

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. As someone who has recently completed an application, your input would be especially useful in the code review group as we work to improve this process.

@markie - We let the issue status automatically go to closed after 2 weeks if nobody comments. It's not a change we make manually. That gives everybody a chance to comment on it while it's "live". Please read http://drupal.org/node/156119.