I have in Image Style preset that uses canvasactions' rounded corners and define canvas actions. The are being exported into a feature. When the feature module in enabled, the imagecache preset is missing the canvas actions. The feature immediately shows that it has been overridden before making any changes to it. Looking at a diff shows that the version on file has the canvas actions definition, but the overridden version does not.

Attempting to revert the feature results in the following:

Notice: Undefined index: isid in image_style_delete() (line 584 of /Users/tom/workspace/repos/alumni/build/modules/image/image.module).
Notice: Undefined index: isid in image_style_delete() (line 585 of /Users/tom/workspace/repos/alumni/build/modules/image/image.module).
Notice: Undefined index: isid in manualcrop_image_style_delete() (line 257 of /Users/tom/workspace/repos/alumni/build/profiles/alumni/modules/contrib/manual-crop/manualcrop.module).
Warning: array_merge() [function.array-merge]: Argument #1 is not an array in image_styles() (line 458 of /Users/tom/workspace/repos/alumni/build/modules/image/image.module).
Warning: array_merge() [function.array-merge]: Argument #1 is not an array in image_styles() (line 458 of /Users/tom/workspace/repos/alumni/build/modules/image/image.module).

Also, as a side-note, when the feature was created, the imagecache_actions module was not automatically added as a dependency.

CommentFileSizeAuthor
#4 error.png65.71 KBpartyzan

Comments

fietserwin’s picture

Status: Active » Postponed (maintainer needs more info)

I am not able to reproduce this error on the current dev version and features 7.x-1.0-rc2. The style does show as being provided by a module (the features generated module) and I cannot directly edit the effects. I have to press the "override defaults" button first. So I guess it has been solved since your report.

That imagecache_actions is not added as a dependency seems a bug in features to me. The effect info provided by modules is extended with the name of the module that implements it. Thus features should be able to add it as a dependency. So, I suggest you post a new issue in the features issue queue for this part of the problem.

dman’s picture

Yeah, I've used features a little for this, and found I had to be sure to add the modules as explicit dependencies.
There is sometimes a pipeline that features export exposes that allows us to detect when a feature is being built and add things to (eg style plugins to views and field modules to content types) that I've worked with before, but when I looked I couldn't force imagecache_actions to notice when an image style was being built.

That may have improved in current D7, but the current work-around is to add the dependency when building it.

fietserwin’s picture

Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)

OK, I created an issue in features: #1578926: Suggest module that defines an image effect as a dependency when exporting an image style containing that effect. Let's see if they can solve that part.

Feel free to reopen this issue if you have more information about the notices and warnings part.

partyzan’s picture

Version: 7.x-1.x-dev » 7.x-1.0
Status: Closed (cannot reproduce) » Needs review
StatusFileSize
new65.71 KB

The same thing , it appears on front page every time after update.php runs

fietserwin’s picture

Version: 7.x-1.0 » 7.x-1.x-dev
Status: Needs review » Closed (cannot reproduce)

#4:
- How is this related to the original bug description? your warnings appear after different actions and in a different function
- What does need a review?

Please explain why you feel that reopening this issue seemed better than filing a new issue, or file a new bug report if you want support on your issue.

partyzan’s picture

Version: 7.x-1.x-dev » 7.x-1.0

Sorry, you're absolutely right, I Just thought that arrays are the same cause I also use the „rounded corners„ - function.