Note to self: track changes in #299138

CommentFileSizeAuthor
#8 html-to-text-loop.txt4.43 KBJorrit

Comments

pillarsdotnet’s picture

pillarsdotnet commented

New patch #299138-155: Improve \Drupal\Core\Utility\Mail::htmlToText()

pillarsdotnet’s picture

pillarsdotnet commented

Applied #299138-157: Improve \Drupal\Core\Utility\Mail::htmlToText() to:

pillarsdotnet’s picture

pillarsdotnet commented

Applied #299138-167: Improve \Drupal\Core\Utility\Mail::htmlToText() to:

pillarsdotnet’s picture

pillarsdotnet commented

Latest is #299138-190: Improve \Drupal\Core\Utility\Mail::htmlToText()
Applied to:

pillarsdotnet’s picture

pillarsdotnet commented

Latest is #299138-198: Improve \Drupal\Core\Utility\Mail::htmlToText()

Applied to Mail System
6.x-2.21 release
7.x-2.21 release
8.x-2.21 release
pillarsdotnet’s picture

pillarsdotnet commented

Full table support added: #299138-230: Improve \Drupal\Core\Utility\Mail::htmlToText()

I can attest that this version does a better job of presenting complex layout than Mozilla Thunderbird in "View message as plain text" mode.

Applied to Mail System
6.x-2.22 release
7.x-2.22 release
8.x-2.22 release
pillarsdotnet’s picture

pillarsdotnet commented

Minor line-wrapping improvements: #299138-232: Improve \Drupal\Core\Utility\Mail::htmlToText()

Applied to Mail System
6.x-2.23 release
7.x-2.23 release
8.x-2.23 release
Jorrit’s picture

Jorrit commented
StatusFileSize
new html-to-text-loop.txt4.43 KB

The latest version is not working well with nested tables. The do { } while($width > 2) loop is taking a lot of time, more than 30 seconds on my server. I have removed all unnecessary parts from the HTML code such that the problem occurs. I have tried to find the problem, but the code is too vague for me.

Maybe I should put this report in #299138, but I see that there are some fixes made to table conversion after June 4th, 2011. Maybe you can check if the attached file parses properly for the new version?

pillarsdotnet’s picture

pillarsdotnet commented
Status: Active » Needs work

@#8 -- Thanks. I'll check.

pillarsdotnet’s picture

pillarsdotnet commented

Thanks very much for the test case; I've added it to the tests for the new version.

I've replaced the linear search with a binary search, and your test case helped me find a few bugs in nested table parsing.

pillarsdotnet’s picture

pillarsdotnet commented

#299138-246: Improve \Drupal\Core\Utility\Mail::htmlToText()
Improved table generation accuracy and performance.
Added test for correctly formed deeply-nested tables.
Test also asserts that table generation takes less than one second.

Applied to Mail System
6.x-2.24
7.x-2.24
8.x-2.24
Jose Chaves’s picture

Jose Chaves commented

Fatal error: Call to undefined function _drupal_html_to_text() in /home/edicoesv/public_html/sites/all/modules/mailsystem/html_to_text.inc on line 559

pillarsdotnet’s picture

pillarsdotnet commented

Thanks; fixed.

Applied to Mail system
6.x-2.25
7.x-2.25
8.x-2.25