Closed (fixed)
Project:
e-Commerce
Version:
5.x-3.0-beta2
Component:
auction
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
9 Feb 2007 at 01:05 UTC
Updated:
1 Mar 2007 at 07:15 UTC
Jump to comment: Most recent file
Comments
Comment #1
wojtha commentedSame problem here. I've found this piece of code in the source of auction module
The problem is that the
product_view()function doesn't exist in the Drupal 5.0 version of product.moduleComment #2
wojtha commentedMaking title more accurate
Missing *place bid button* solved here: http://drupal.org/node/118076
Comment #3
gordon commentedThis is correct product_view() is no more. This is now handled by the nodeapi()
This function needs to be converted into a nodeapi function.
Comment #4
wojtha commentedHi!
I've made port to D5, using nodeapi view instead of the product_view as neclimdul and gordon advised me.
I think the code need some work to be 100% Drupal 5, but it seems to work without problems in the D5 now.
Comment #5
neclimdulThanks for the start. Could you update so the latest changes are present(hook_link) and clear out the odd spaces so the patch just contains the changes you've made?
Also, could you change your editor to use spaces instead of tabs? This is compliance with the drupal coding standards. If you haven't glanced through the standards they are in the handbook. Thanks!
Comment #6
wojtha commentedStrange thing with the tabs, I had Eclipse set to *space intendation*, I have to change tabs to spaces in some other editor.
So here is a rerolled patch against newest dev cvs DRUPAL-5--3 branch (11 Feb 2007 19:11:52 1.19.2.3.2.1.2.8). I made some structural changes, clean code a little and add few comments to the code.
Comment #7
wojtha commentedI've been testing the patch further today, and I've found bug. Please don't use my patch for now. The problem is, that every product is now rendered as an auction ... My patch is a little alien ;-)
I'm going to fix it. Sorry for that.
Comment #8
wojtha commentedHere is rerolled patch. I've also fixed some another bug - user, who went to checkout had to pay all of his bids, not only the winnig bids.
Comment #9
simeThanks @wojtha !!
Great patch, I'll take that anytime.
http://drupal.org/cvs?commit=56377
Comment #10
(not verified) commented