Closed (fixed)
Project:
jPlayer
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
31 May 2011 at 00:05 UTC
Updated:
12 Oct 2011 at 23:01 UTC
Jump to comment: Most recent file
Comments
Comment #1
deviantintegral commentedHere's a patch against 6.x-1.x withe the following commits:
Comment #2
deviantintegral commentedHere's a new patch with a few more commits. We now prevent clients from setting their clock to be too far in the future, increased the default window to 30 seconds, and only allow access to a file once.
Comment #3
deviantintegral commentedNew commits:
Also, it looks like there is an issue with Chrome where it double-requests audio files. The second request is denied (since the token has expired) breaking the player. It works fine in other browsers, or if the flash player is used. I'm going to look into this some more, but I'm thinking that if the browser is chrome, download protection is on, and flash is available, that the flash player should be forced.
Comment #4
deviantintegral commentedHere's a new patch that fixes the issue with Chrome requesting a file multiple times.
Comment #5
deviantintegral commentedHere should hopefully be a final patch that adds logging for when files are blocked and provides a table of the top-denied users. That way, admins can contact or block users who are trying to download files (or be aware of any possible browser issues).
Comment #6
deviantintegral commentedComment #7
deviantintegral commentedTwo more. The big change is that private downloading can be enabled even if the access is public, in case a custom .htaccess rule is redirecting access to system/files.
Comment #8
deviantintegral commentedImplementing hook_install() and uninstalling our variables in hook_uninstall().
Comment #9
deviantintegral commentedHere's an additional fix that cleans up detecting when the "playlist" player is in use. Otherwise, the wrong file path is sent to the server. This adds a playerType variable to the player that can easily be used by other JS functions.
Comment #10
deviantintegral commentedI curse IE to as much pain as it has caused me.
Comment #11
izmeez commentedsubscribing
Comment #12
deviantintegral commentedThis needs to be ported to 7.x-2.x. It's large enough that I'm hesitant to commit it to 6.x-1.x by itself.
Comment #13
deviantintegral commentedHere's an untested reroll against the latest 6.x-1.x. Once I've tested that the rebase didn't break anything, I'll start porting to 7.x-2.x.
Comment #14
deviantintegral commentedI've attached a patch porting all of the changes to 7.x-2.x. I've posted it here for reference, but I'll be committing a squashed version of it along with the 6.x-1.x version.
Everything works in the 7.x-2.x version, but there are still some TODOs left. I'm going to file separate issues for everything else left to be done.