The embedded soundcloud player does not appear in PHP 5.3. This seems to be the usual issue with call_user_func_array($func, $args), where $func() must NOT expect any arguments to be passed by reference.

Because emaudio_soundcloud_preview() does not modify the &$node - or indeed refer to it at all, as it just calls a theme() function with the other args - then the reference ampersand can be removed.

Please find attached a simple patch to do this. ewills reported this on #1166760-1: Supported features do not seem to work but I'm spinning it out into a separate issue for clarity.

(PS re: 5.3 support - I know, I know; but this is a quick fix and has no impact elsewhere.)

CommentFileSizeAuthor
#3 soundcloud-php-5.3-by-reference-bug-v2.patch.txt1.01 KBvictoriachan
soundcloud-php-5.3-by-reference-bug.patch.txt599 bytesjp.stacey

Comments

joachim’s picture

joachim commented
Status: Needs review » Fixed

Thanks!

Issue #1174018 by jp.stacey: Fixed PHP 5.3 pass-by-reference warning.

Committed and will shortly be available in the dev release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

victoriachan’s picture

victoriachan commented
Status: Closed (fixed) » Patch (to be ported)
StatusFileSize
new soundcloud-php-5.3-by-reference-bug-v2.patch.txt1.01 KB

There's another of these pass by reference ampersand in the emaudio_soundcloud_audio($embed, $width, $height, $field, $item, &$node, $autoplay) function.

I'm submitting a modified version of the patch above to remove both instances of the pass by reference ampersand.

Thanks!

joachim’s picture

joachim commented
Status: Patch (to be ported) » Closed (fixed)

Could you file that as a new bug, and a fresh patch please? The patch has already been committed (hence 'fixed') so your patch will not apply.

joachim’s picture

joachim commented

Has been filed and fixed over at http://drupal.org/node/1035178