This module allows Drupal users to embed our points based poker (fun only) games into their website in an IFRAME or POPUP window. The end user is automatically logged in, or registered, in the game system using their Drupal username so that there is no need to re-register to play. To the player it appears to be a seamless integration.

By default the module displays shared game tables that also appear on other websites. But if the Drupal user rents private games from our website www.justforfunsoftware.com and obtain and customer id #, they can enter this id# into the module settings.

The sandbox project is at http://drupal.org/sandbox/JFFSoftware/1173690

ZIP of module attached.

CommentFileSizeAuthor
poker.zip3.11 KBJFFSoftware

Comments

alexreinhart’s picture

Status: Needs review » Needs work

You should run your module through the Coder module to check for style and formatting; for example, lines should be indented with two spaces, and there should be a space before opening braces. The Coder module will give you automatic feedback to help fix these issues. Note that the $Id$ lines are no longer required because drupal.org uses Git instead of CVS.

Other comments:

  • poker_menu() does not need to use t() on the 'title' attributes, since that is done automatically. Check the hook_menu docs.
  • Your .info file shouldn't contain the "; Information added by drupal.org packaging script on 2009-07-02" line or anything below it; that will be added by drupal.org when you make a release of your module.
  • It seems to me that admin-controlled settings like "poker_block_iframe_height" are never sanitized, so if anyone with the "administer poker setting" permission types raw HTML in rather than a number, it will be output directly. You should use the form API validate functions to prevent this, or use check_plain() when displaying the HTML.
  • In poker.admin.inc, every #title and #description should be wrapped in t() so it is translatable.
  • poker_link() outputs phrases like "Click to Play" and "Game Lobby", which should be translatable. Wrap them in t() and concatenate them into the output string.

I hope that helps. You've certainly been sitting in the review queue for a rather long time.

klausi’s picture

Status: Needs work » Closed (won't fix)

No activity in several months. Reopen and set the status to "needs review" if you are still pursuing this application.