The page title and menu entry "Translator assigments" should be "Translator assignments" (there's an "n" missing).

CommentFileSizeAuthor
#5 Rename-assigment-to-assignment-1174330-4-D7.patch2.98 KBAndrew Schulman
#4 Rename-assigment-to-assignment-1174330-4-D6.patch2.64 KBAndrew Schulman
#4 Rename-assigment-to-assignment-1174330-4-D7.patch2.91 KBAndrew Schulman
#2 1174330.patch1.66 KBAndrew Schulman

Comments

Andrew Schulman’s picture

Andrew Schulman commented
Priority: Normal » Minor
Andrew Schulman’s picture

Andrew Schulman commented
Title: "Translator assigments" is misspelled » "assigments" is misspelled
Status: Active » Needs review
StatusFileSize
new patch1.66 KB

This happens in the "view translation overview assigments" permission too. Patch attached to fix all cases.

lklimek’s picture

lklimek commented

I think you should also write update code to rename permissions stored in database when this module is updated. Otherwise current permissions won't work after applying this patch, what can lead to confusion.

Andrew Schulman’s picture

Andrew Schulman commented
StatusFileSize
new Rename-assigment-to-assignment-1174330-4-master.patch2.91 KB
new Rename-assigment-to-assignment-1174330-4-6.x-2.x.patch2.64 KB

Good point. Here are patches that do this, against the latest Git master and 6.x-2.x branches. I've tested them both on my host and they work as desired.

Andrew Schulman’s picture

Andrew Schulman commented
StatusFileSize
new Rename-assigment-to-assignment-1174330-4-master.patch2.98 KB

Revised patch against master, includes a return message from the update.

lklimek’s picture

lklimek commented

Patch #5 on Drupal 7 (master branch) works for me.

stefan.r’s picture

stefan.r commented
Version: 6.x-2.4 » 7.x-2.x-dev
Issue summary: View changes
Status: Needs review » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.