Keep original posters IP address on move

yngens - February 9, 2007 - 10:25
Project:Comment mover
Version:6.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:postponed
Description

Hi,

Subject pretty much says about this problem, which I consider a serious bug. If you have ip2cc module installed and flags for comments activated, then you can not moderate threads by comfortably moving the comments around, because every moved comment changes its flag to the country flag of the moderator. And this is not desirable at all since it is confusing the users, who notice their flags changed and causing them ask lots of justified questions.

In my opinion, the module should preserve IP address of any moved comment, thus not changing flags of the countries.

#1

Heine - February 9, 2007 - 10:43
Priority:critical» normal

Not critical. This is due to code in comment.module (comment_save).

Perhaps we need a bit of code to 'fix' the first moved comments once saved. Not really clean, but don't see another way.

#2

yngens - February 11, 2007 - 05:26

Thanks for explanation. Well, one way or another this issue should be solved.

#3

yngens - February 13, 2007 - 13:18

Heine, could you please give me any clue of when approximately this issue could be solved. I have a forum with many branches and need to periodically move comments around, but reluctant to do that now because moved comments are changing their country flags.

#4

yngens - February 24, 2007 - 11:32

Probably, this issue should be resolved at more systemic level than of this module. I have created a ticked "Author's IP changes to admin's one when editing and saving nodes" here http://drupal.org/node/122105, because not only comments' IP changes when editing, but also of edited nodes.

#5

DanielTheViking - June 10, 2007 - 11:27

Subscribing

#6

dragonwize - March 21, 2009 - 07:44
Title:The module wrongly changes IP addresses. Moved comments' flags automatically are assigned to admin's country flag with ip2cc.» Keep original posters IP address on move
Category:bug report» feature request
Status:active» postponed

I will keep this in mind during my rewrite of this module. However, since core handles the IPs, I don't want to bloat the module with crazy code that will cause issues. So if I find an elegant way of doing this I will include this feature. Otherwise we will have to wait for a fix to be committed to core.

#7

DanielTheViking - August 23, 2009 - 20:57
Version:5.x-1.x-dev» 6.x-1.x-dev

FYI - I filed a feature request against D7 with reference to this post here:

"Keep current authors IP address when others edit the node"
http://drupal.org/node/557340

 
 

Drupal is a registered trademark of Dries Buytaert.