Additional Query for taxonomy term field

subscribe

Yes, ":" is a special character in lucene syntax.

The field names in the index DO NOT match the field names in the DB, so not of your filters above will work.

However, the simple filter tid:84 should work.

I think khiminrm is saying that the apachesolr module is inserting the ":". And I think it is due to

$query->addFilter('', $custom_filters);

in apachesolr_mlt_suggestions. Fixed in patch.

Maybe we need some other cleanup of that MLT code too?

For the custom search pages I think it's taking a comma-separated list.

Wouldn't it work as-is if it were a space-separated list instead?

No, since you can have a query with e.g. (X OR Y) groupings that contain spaces, or range queries with spaces.

@pwolanin: K. It occurs to me that if there is a range query anywhere in the string, we should not double quote. Included that fix in the patch.

@khiminrm: Did you enable the Solr filter for the taxonomy product_availability?

It sounds like there are more bugs in the "more like this" feature that we need to fix. I don't have time to look into it right now, though.

After changing

$filter['#value'] = '"' . $filter['#value'] . '"';

to this:

$filter['#value'] = $filter['#value'];

It was working for me, in addition to patch

So, I upload valid patch for me. Unless somebody can tell me why there are needed quotation marks in
$filter['#value'] = '"' . $filter['#value'] . '"';

+++ Solr_Base_Query.phpundefined
@@ -121,17 +121,23 @@ class SolrFilterSubQuery {
-    $prefix = empty($filter['#exclude']) ? '' : '-';
+    $prefix = '';
     if ($filter['#local']) {
-      $prefix = '{!' . $filter['#local'] . '}' . $prefix;
+      $prefix .= '{!' . $filter['#local'] . '}';
+    }
+    if (!empty($filter['#exclude'])) {
+      $prefix .= '-';

This seems wrong to me?
Are you sure the exclude has to appear after the local parameter?

+++ Solr_Base_Query.phpundefined
@@ -121,17 +121,23 @@ class SolrFilterSubQuery {
-    if (preg_match('/[ :]/', $filter['#value']) && !preg_match('/^[\[\{]\S+ TO \S+[\]\}]$/', $filter['#value']) && !preg_match('/^["\(].*["\)]$/', $filter['#value'])) {
-      $filter['#value'] = '"' . $filter['#value'] . '"';
+    if (preg_match('/[ :]/', $filter['#value']) && !preg_match('/[\[\{]\S+ TO \S+[\]\}]/', $filter['#value']) && !preg_match('/^["\(].*["\)]$/', $filter['#value'])) {
+      $filter['#value'] = $filter['#value'];

Also, I don't see the need in changing these regular expressions? If the only thing you want is to remove the name and only set the value you shouldn't need those changes right?

I had the same issue today with our related content block (powered by MLT) was bringing content in from other sites (we have one index for all sites). The same error was raised as in #1.

I stumbled upon this issue after reading through some code and see there was a @todo for handling comma-separated custom filters. Here's my initial thought:

     if ($custom_filters = $settings['mlt_custom_filters']) {
       // @todo - fix the settings form to take a comma-delimited set of filters.
-      $query->addFilter('', $custom_filters);
+      // mlt_custom_filters are comma delimited, name:value pairs.
+      $filters = explode(',', $custom_filters);
+      foreach ($filters as $filter) {
+         list($key,$val) = explode(':', $filter);
+         $query->addFilter($key, $val);
+      }
     }

Certain fields in SOLR require quotes (like string) whereas text fields don't (if you're doing a search and don't want a literal match). If the field you're filtering by requires quotes, just place them into the custom filter input box vs. fussing with a regex on the code side.

Negation logic can be added to the code above without much effort.

My two (maybe only one, heh) cents....

Could you please make this a real patch? And also describe a test case where the original code fails and the modified one succeeds?

Same issue, tried to add a filter from the MLT config to show results only for date created in a certain range (which is on the description in the form field). No matter what I enter, no results come back, and the server returns a ''bad request'' error from including the ds_created:[DATE TO DATE] filter. If I remove it, it works fine.

I'm also running into this issue. I have a custom field in my solr index and whenever I try to filter based on the field, it creates a bad request because of the colon at the beginning.