Bug fixed in taxonomy_menu.database.inc

There was an error in 1.1 version for D7 (maybe it is already fixed in repository). I am not comfortable with D7 API (only D6), so may be I am wrong somewhere, please check me.

First issue:

function _taxonomy_menu_get_terms($vid) {
  $result = db_select('taxonomy_term_data', 'td')
    ->condition('vid', $vid)
    ->addField('td', 'tid')
    ->execute();
  return $result->fetchAll();
}

addField returns new field alias, not SelectQuery object, so we get an error here (PHP says that could not do ->execute() on non-object). Also this function is recommended to use just when we need to know assigned alias, otherwise we could use ->fields() (http://api.drupal.org/api/drupal/includes--database--select.inc/function...).

My variant:

function _taxonomy_menu_get_terms($vid) {
  $result = db_select('taxonomy_term_data', 'td')
    ->condition('vid', $vid)
    ->fields('td', array('tid'))
    ->execute();
   
  return $result->fetchAll();
}

2) Issue like previous one in the same file:

function _taxonomy_menu_get_vid_by_tid($tids) {
  if ($tids) {
    $result = db_select('term_data')
      ->condition('tid', $tids, 'IN')
      ->addField('vid')
      ->distinct()
      ->execute();
    $vids = array();
    return $result->fetchAllAssoc('vid');
  }
}

There is ->addField()->something. And maybe one more error: addField requires 2 arguments (table_alias, field), so may be right code looks like:

function _taxonomy_menu_get_vid_by_tid($tids) {
  if ($tids) {
    $result = db_select('term_data')
      ->condition('tid', $tids, 'IN')
      ->fields('term_data', array('vid'))
      ->distinct()
      ->execute();
    $vids = array();
    return $result->fetchAllAssoc('vid');
  }
}

But in that case I am not so sure.