Have theme('image_style') inject the style name as a class

Ooh. I like this.

This require a tests to ensure that class injected

Postponing on #1696416: Regression: theme_image_style() is broken.
I'll work on this once that's in.

Well, went ahead and rolled it anyway. Assumes the other issue was committed.

Rerolled since that went in.

Had to add the class to output in a couple other places.

Missed one more.

+++ b/core/modules/image/image.moduleundefined
@@ -1197,6 +1197,8 @@ function theme_image_style($variables) {
   $variables['height'] = $dimensions['height'];
 
+  $variables['attributes']['class'][] = 'image-style-' . drupal_html_class($variables['style_name']);

Any reason we prefix the style name (with 'image-style-')? Just wondering as it seems a bit redundant to me.

The changes to other tests that don't even care about this class are not ideal. Postponing this on #1706878: Add WebTestBase::assertThemeOutput() to allow modules to test theme function output

Nevermind, this seems a necessary evil.

#12: drupal-1175764-12.patch queued for re-testing.

Rerolled due to #1446464: Get rid of file_field_load() - shouldn't load all file object data with field load - only file ID

Rerolled after #1742958: All spellings of URI should be uppercase

no brainer

Will this be comitted to D7 as well? Or just D8?

@Pixelstyle it's tagged for backport, but that decision lies with the branch maintainer. Either way, it has to go into D8 first.

Seems like a nice improvement, and we are currently under thresholds.

Committed and pushed to 8.x.

Since this is only adding a new class, and not changing any existing ones, I think backporting it is probably kosher (subject to overruling by David_Rothstein, of course).

I don't have time to reroll this myself, but it wouldn't be too hard.

I don't know if I ported all the tests correctly, let's look at what the bot says.

Let's try again.

Just tried to apply this and received the error:

error: patch failed: modules/image/image.module:1262
error: modules/image/image.module: patch does not apply

Does it need to be re-rolled for the latest version of 7.x ?

#29: 0001-Issue-1175764-by-tim.plunkett-Rob-Loach-eojthebrave-.patch queued for re-testing.

The patch does apply to latest 7.x branch using git am. I think there are some image tests added later that are failing. Let's try this.