At the moment, the output of the diff comparison table has serious potential to break layouts when long non-breaking lines are encountered (such as URL's). This becomes a bigger issue when the right column is being used as the text overlaps and gets convoluted. This can't be fixed by simply editing diff.css as the <td>s probably need <div> tags in order to apply a style property such as overflow:auto. This led me to the larger issue of the table output not being themeable since it's mostly hard coded in DiffEngine.php

Themeable table output would allow people to easily fix this and other layout issues however they see fit.

I'm not sure how to proceed, however:
1. I'd probably go with creating theme_diff_ functions to replace the various functions in the TableDiffFormatter class in DiffEngine.php; but there's also the theme_table function that could be used here as well. -any thoughts?

2. I don't think that any changes would need to be made to DiffEngine.php, but if there are, is that appropriate?

thanks in advance for any guidance on this

Comments

moshe weitzman’s picture

moshe weitzman commented

I would like to see diffEngine to be rewritten so it conforms to drupal code standards. that means that it uses proper indentation, syntax, and also uses theme functions like theme('table')

rötzi’s picture

rötzi commented

I'm done with indentation and overall layout. I haven't done the theme functions yet. I will update when this is done.

BioALIEN’s picture

BioALIEN commented

Rotzi, any more news on this please?

rötzi’s picture

rötzi commented

See here: http://drupal.org/node/125494

moonray’s picture

moonray commented
Status: Active » Closed (duplicate)

Marking as duplicate of: http://drupal.org/node/198918