Remove button does not respect changing of the override select

The code at the top of views_ui_standard_submit() has to be executed on views_ui_config_item_form_remove as well.

Just to write down for the person who fixes this.

subscribe

This is an artifact of changing override from a button to a select, it looks like. This is somewhat related to #1174070: Improve UI for "Apply (this display)" though it is not actually the same thing, but it's a similar thing that wasn't, unfortunately, well considered in the new UI.

This patch would work in theory BUT the problem is that form_state['values'] is pretty much empty in views_ui_config_item_form_remove

Any idea what the reason could be?

Perhaps views does something special with #validate or #limit_validation_errors

does somebody has an solution?

Everytime you write a comment like this in the issue queue two kittens die.

subscribe i have the same problem

@delta, @sachbearbeiter
You subscribed here so you should read this via mail :) Please test the patch!
If you think it's important, as you did because you posted something here, please test the patch.

Just tagging to catch them all.

subscribe

Feel free to look at the other issues with the same tag.

In general this patch doesn't apply at the moment so there is work todo.

Here is a rerole of the patch.

Hi

I tested the patch and it didn't seem to work; same problem occur.
I'll take a closer look to the code later on today or tomorrow.

the question I'm thinking is: should this really even be possible? Should an admin be able to set it to override and therefor expect it to be overriden before saved?

I made the same changes that the patch above + changed in views_ui_standard_override_values

#16 didn't work, but #18 works perfectly.
As long as the s/values/input in the middle hunk is okay, this is good to go. I'm not 100% sure about that change, but it seems reasonable.

The problem is: why is input required here. Well in fact you can validate the override part and everything is fine.

Awesome! Thanks earl!

I really need to learn more about #limit_validation_errors. This also works, and makes more sense.

YEAAAH

Release feels pretty close.

please feel free to explain this more in detail, eager to learn

Okay: if you have a #limit_validation_errors on a submit button you can limit the form elements which are validated.

Only validated form elements set values to $form_state['values']

So we need the form elements from form $form['override'] so we only validate this values.

hi

a big aha from me :) A way smarter and more correct solution than the one I gave.

thanks for your time

No thank you for providing an initial fix :) This leads to the idea how to fix it perfect.