Workflow Access Extension

This seems like a major improvement to workflow module.

I would be careful with one thing: the workflow edit form can get quit long and if you have more then 10 roles and 10 states it can became impossible to edit (lots of php memory and even browser problems). Even today it would be important to separate worflow transition permissions and workflow access permission to different pages or to make a filtering system (like this one: http://drupal.org/project/filter_perms ). If you're going to add even more things to the same page...

Finally, workflow module, although with lots of users, is in effect almost abandoned by its maintainers. All feature requests are being ignored, port to Drupal 7 didn't even started, the last significant improvement was the porting to Drupal 6 and even ready patches are hardly being committed. I think Davyin Internet Solutions contribution will be very, very welcomed.

Thanks for your comment. We will try to optimize it. I beleive workflow will not die.

Hello,

I'm having problems with module: Workflow_features_extention (missing)

Bravo! A wonderful addition conceptually though I haven't had a chance to test it. Looking at workflow_userreference_access.module, line 169, I see you don't have priority set high. My experience from using the workflow_access module in the context of Open Atrium (which for this subject, the OG Spaces module is really what we're dealing with), I had to set the priority above that of OG otherwise as long as a user had membership to a group they were granted view privilege and edit privilege if the node type was set to "Wiki group post". It seems workflow_access module and this group of modules could benefit by having a "Set grant priority" setting similar to what the Nodeaccess module has (just a checkbox for granting priority for Nodeaccess grants).

For now, I wouldn't worry about additional settings or admin form modifications as Encarte suggests. Making sure it works "as is" should be priority.

Is it safe to assume that this is a beta of the Workflow module?
Thanks,

FYI.
We have already used it in production site. :)

Hi Alfababy - sorry it's taking so long for your review. I think the area of knowledge needed to review this is pretty specific making it harder for people to review it.

It seems like you've got a few issues in the queue - http://drupal.org/project/issues/1172924?categories=All - it would be great for you to respond to those and help close them. In particular #1267490: Transition from / to seems like an important one to address.

Suggestions

Your .info files have windows new lines and should be switched to unix line endings.

Please remove the $Id$ from all files - this is no longer useful now that drupal.org is on git.

workflow_rolereference_access_schema looks like it uses tabs instead of 2 spaces sometimes and doesn't follow standard array indentation. The same problem is in a few places of workflow_transitions_access and workflow_userreference_access.install and all the module files.

Other than that the code looks relatively good.

Whoops, forgot to mark needs work. I'd love to get one more set of eyes on this and fixing the tabs/formatting issue should be easy and should make it easier to review.

Is #8 solved? I'm thinking about testing the module but would rather do it with #8 issues already solved.

yes, all issues have been fix. Please go ahead. We are currently porting it to D7 version.

Workflow for D7 was just releases, there are a number of changes in available functions that you'll want to keep an eye out for. Let me know how this goes, I'd love to be able to point people to this where they need more complex user permissions.

As a side note - would it be helpful to have any hooks in place in workflow_access to make this easier on your end? If so - let me know.

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• README.txt is missing, see the guidelines for in-project documentation.
• Remove "version" from the info file, it will be added by drupal.org packaging automatically.
• ./workflow_transitions_access.features.inc: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  

  function workflow_trans_access_features_export_options() {
  function workflow_trans_access_features_export($data, &$export, $module_name = '') {
  function workflow_trans_access_features_export_render($module, $data) {
  function workflow_trans_access_features_revert($module) {
  function workflow_trans_access_features_rebuild($module) {
  

• ./workflow_userreference_access.features.inc: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  

  function workflow_uref_access_features_export_options() {
  function workflow_uref_access_features_export($data, &$export, $module_name = '') {
  function workflow_uref_access_features_export_render($module, $data) {
  function workflow_uref_access_features_revert($module) {
  function workflow_uref_access_features_rebuild($module) {
  

• Bad line endings were found, always use unix style terminators. See http://drupal.org/coding-standards#indenting
  

  ./workflow_rolereference_access.info:         ASCII text, with CRLF line terminators
  ./workflow_transitions_access.info:           ASCII text, with CRLF line terminators
  ./workflow_userreference_access.info:         ASCII text, with CRLF line terminators
  workflow_rolereference_access.info
  workflow_rolereference_access.module
  workflow_transitions_access.info
  workflow_transitions_access.module
  workflow_userreference_access.info
  workflow_userreference_access.module
  

• Remove all old CVS $Id tags, they are not needed anymore.
  

  workflow_rolereference_access.info:1:; $Id: workflow_rolereference_access.install
  workflow_rolereference_access.install:2:// $Id: workflow_rolereference_access.install, 2011/03/21 12:55:12 stephen.shi Exp $
  workflow_rolereference_access.module:2:// $Id: workflow_rolereference_access.module, 2011/03/21 12:45:18 Stephen.Shi Exp $
  workflow_transitions_access.info:1:; $Id: workflow_transitions_access.info
  workflow_transitions_access.install:2:// $Id: workflow_transitions_access.install, 2011/03/10 10:30:09 stephen.shi Exp $
  workflow_transitions_access.module:2:// $Id: workflow_transitions_access.module, 2011/03/15 19:23:11 Stephen.Shi Exp $
  workflow_userreference_access.info:1:; $Id: workflow_userreference_access.info
  workflow_userreference_access.install:2:// $Id: workflow_userreference_access.install, 2011/03/10 10:30:09 stephen.shi Exp $
  workflow_userreference_access.module:2:// $Id: workflow_userreference_access.module, 2011/03/10 10:23:11 Stephen.Shi Exp $
  

• Run coder to check your style, some issues were found (please check the Drupal coding standards). See attachment.
• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

alfababy,
Just curious to know when you might have time to apply the reviewers recommendations, finalize and promote this module here on D.O.

Thanks!

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

There are still several issues reported by PAReview:

Master Branch

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

Additionally its very hard to read through your code. Please have a look at the Drupal Coding Standards and re-format your code. While applying the coding standards consider commenting your code (see Doxygen and comment formatting conventions. There are large code blocks without any comments so its very hard to understand whats going on there and why the code is just like it is.

duplicate of #1927636: Grid Field Formatter.

klausi,
I don't understand how this is a duplicate of the Grid Field Formatter project. Workflow Access Extension is completely different. Maybe I don't understand how the status field is used in the Project application queue?

alfababy,
I also don't get why you marked this as "closed (won't fix)" but made a statement indicating you would be back working on the project soon. Can you clarify whether you will be pursuing the Workflow Access Extension project application?

Thanks!

@timwood: one applicant should only have one project application active, all others of the same applicant are duplicates.

Thanks for clarifying.

Moving this project application to the Workflow issue queue. Although it is not active anymore, people may find it more easily, and take the ideas.

Main reason being that I've mostly moved to D7 and this could be achieved in other ways, that wouldn't necessarily require this module anymore.

I've been researching this for a while now (allowing a user specified in an entityreference field on a node to make only certain state changes), and have been unsuccessful thus far. Might I ask to which other ways were you referring?

Or am I looking at a custom hook_workflow_permitted_state_transitions_alter implementation based on a user entityreference field?

@wordlfallzz, commenting on closed issue normally falls below the radar :-(

This thread is about a D6 sandbox project. If you want this in the D7 Workflow module, please open a new issue with reference to this one. D7 has a massive rewrite. And yes, the hook_workflow_permitted_state_transitions_alter gives you much context to decide upon the available states for a given user.