Diff shows HTML

MatthewS - February 9, 2007 - 22:56
Project:Diff
Version:4.7.x-1.x-dev
Component:User interface
Category:support request
Priority:normal
Assigned:Unassigned
Status:closed
Description

I've downloaded the lastest version of Diff and have a question.

1) When I look at revisions, it gives me an HTML view. Is there any way for the HTML to not show as code?

Thanks,
MatthewS

#1

moshe weitzman - February 10, 2007 - 04:20

no. we show the differences in user input between two revisions. if users entered HTML, thats whats shown. The old way didn't really look or work very good.

#2

toemaz - February 10, 2007 - 17:27

I agree on Moshe's feedback.

#3

MatthewS - February 12, 2007 - 17:18

Aha. Ok. I'm using TinyMCE to make text look "good" to clients (both internal to my organization and external to) so it seems that we might need to choose to not use TinyMCE if we want to use Diff in a readable way.

#4

rötzi - March 7, 2007 - 08:37

#5

Fool2 - March 30, 2007 - 18:11

A possible solution:

Convert formatting to some readable, non-html entity.

For instance,

<font color="blue">

could be converted to

[COLOR:BLUE]

which, when diffed, (say if you changed the color to red) would show

[COLOR:<html formatting for diff minus>BLUE</><html formatting for diff plus>RED</>]

I think this would still alow people to track formatting changes without freaking the layperson out with html code (especially broken html code).

We shouldn't really be SEEING the formatting (aside from linebreaks) anyway as there is always the possibility that diff formatting conflicts with the formatting in the document.

The possible issues, however:

-Closing tags might still freak people out (how to encapsulate a formatted piece of text without them?)
-It would still pale in comparison to tools like "track changes"
-It might be more work than its worth

#6

jonnyz - April 10, 2007 - 21:38

rotzi did a great job at addressing this issue using a setting in the admin area that allows you to specify whether you want the user to see all the markup or strip out html. I tested it out at some point and it worked great. He mentioned that he would work on getting it integrated at the end of march but i don't know where it stands. it had a bunch of other great changes as well built into that release. moshe...maybe you could work with rotzi to integrate? i don't code myself but would be more than happy to help test.

jz

#7

moshe weitzman - March 12, 2008 - 00:16
Status:active» closed

4.7 is old, and i'm not sure there is any todo here. i think the current diffs work nicely. please reopen as needed.

#8

yurtboy - July 2, 2008 - 14:08

is this patch still working for the latest release of this module and drupal 5.x?

 
 

Drupal is a registered trademark of Dries Buytaert.