Delete button on clone page is confusing

I cannot reproduce this, e.g. by cloning the "main" profile and putting in the machine-name "main" in the clone, I get a validation error. Can you reproduce it? If yes, what are the exact steps?

Hi jucallme, it looks like there are two separate issues you're dealing with here.

First, when you go to clone a profile type, there are two buttons marked "Save profile type" and "Delete profile type". This is confusing because the first button means you will save the new clone-copy profile type, but the second button means you will delete the original cloned-from profile type. Adding to the confusion is that there is no "Cancel" or "Go back" button, which is actually the option you were looking for.

So we may want to consider this issue as a UI bug, and maybe a patch that just clarifies the two buttons better is sufficient. Another option is to add a Cancel button, and/or remove the Delete button.

The second issue you're dealing with is an error message that I can't replicate. I did a quick search though and you may want to look at some related discussions:

- Creating field instance during hook_insert() causes PDOException: http://drupal.org/node/1182010
- #687180: Deleting a taxonomy vocabulary leaves term reference fields still pointing to it, and a PDO Exception when creating content
- #1007830: Nested transactions throw exceptions when they got out of scope

Thanks,
Eric

Given the extra confirmation page that clearly tells you which profile type is going to be deleted, this doesn't seem like a major issue.

Another option is to just remove the delete button from the clone page, so it's more like the add page:

  if (!$profile_type->isLocked() && $op != 'add') {
    $form['actions']['delete'] = array(
      '#type' => 'submit',
      '#value' => t('testDelete profile type'),
      '#weight' => 45,
      '#limit_validation_errors' => array(),
      '#submit' => array('profile2_type_form_submit_delete')
    );
  }

Here's a patch to remove the delete button from the clone page, so it's more like the add page.

A cancel button would probably be nice too, but it's not necessary. When you add a new profile type, there is no cancel button, you either save the new profile type or you don't. The clone process could be the same way. I think the more important problem is that the delete button is confusing.

thanks, committed.