Issue: http://drupal.org/node/1174620
Test: http://drupal.org/files/issues/1174620-html5-email-element_2.patch

The patch changes the e-mail address fields on the last-step-configure form of the installer from <input type="text" ... /> to <input type="email" ... />. I have no idea why this would cause a failure as the install script is set up to look for the form fields by name, which remains unchanged with the patch. I've also manually tested this with several fresh D8 installs with the patch applied and I encounter no problem submitting the last-step form or the install in general.

Randy is already looking into this.

Comments

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

Thanks for the issue.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

And thank you randy for your work looking into this. I reached the endpoint of being able to debug this effectively. :/

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

We finally have what's wrong - PIFR uses SimpleTest 6.x-2.x to do the initial install/test of core patches (for D6 and onward) and not the version that's available in the version of core being tested. So even though #1174620: Add new HTML5 FAPI element: email properly modified DrupalWebTestCase::handleForm() for the new elements, the version used to test the install does not, hence the email fields do not submit.

I have committed a fix in SimpleTest 6.x-2.x: http://drupalcode.org/project/simpletest.git/commit/c4d3a3e

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Alright, now we just need to figure out what/how/if new code needs to be deployed to the testbots.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

So it turns out that we are already using simpletest in the latest commit. (boombatower had *just* changed it to do so. Confused the dickens out of me.)

I've added a line to the drush make in the drupaltestbot package that grabs the version of simpletest you did. I think that should do the trick.

So we can probably deploy this with a couple of other things this weekend or Monday or something. We should get it.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Active » Fixed

It *looks* to me like we got this one.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.