Hi,

xmlrpc_server.module contains a call to an undefined function called service_get_all(), which I think should be services_get_all(). Am I missing a file somewhere or is this a bug? A grep of my drupal install only yields the one call to this function, and not a declaratioon of the function itself. I went ahead and changed it to services_get_all() as a test, which produced a blank page afterwards. That file - and at least one other - are also missing closing ?> tags. I submitted this as support seeing as I'm not sure if I am up late and wonky or if there's actually something amiss here.

Thanks for the module. Can't wait to get it working with Flex!

- aym

Comments

snelson’s picture

snelson commented

Just committed, good catch ... I've been working mostly with the AMFPHP server and not so much XMLRPC, so I didn't see it. I actually recommend you use AMFPHP for Flash and Flex stuff, so that you can use remoting and Flex data services. About the closing ?> tags, these are not needed and its a Drupal coding standard not to have these, just look at core files. This prevents you from have any rogue line breaks at the end of you modules, which will break everything.

Oh, if you don't have a declaration of the function itself, you need to download the latest version of Services. It's changing pretty frequently, so I recommend you checkout head from cvs, if you know how. Or just keep on top of updates.

It'll take at least a few hours for that last commit to get into the .tar package download.

Thanks,
Scott

averageyoungman’s picture

averageyoungman commented

Thanks!

Sorry to draw your focus from the commits. Been working with Flex/Flash so much I'd forgotten about the dreaded erroneous line break and resulting blank page. Should have known. I had checked CVS but I usually stick with the releases if I can, especially since this is my first foray into Drupal 5 - which marks some really impressive improvements I might add; what a difference. I will keep on top of releases and HEAD, and attempt to use AMFPHP instead of XMLRPC (the speed increases in 1.9 sound unbelievable). My experience has been with the latter. Hopefully at some point I will be experienced enough with this module to contribute.

Thanks again. This is a huge contribution to Drupal and Flex/Flash developers everywhere. I have the feeling it's going to see some pretty heavy usage!

snelson’s picture

snelson commented
Status: Active » Closed (fixed)