Description

This module integrates the Feedbackify service with Drupal. The Feedbackify service integrates a very sleek and lightweight feedback form into your website. The module helps you to quickly customize the button colour, position and on which page it will be displayed.

You do need a Feedbackify account in order to use this module, but there is a 15 day free trail.

Project Page: http://drupal.org/sandbox/ivanbreet/1174360

Comments

Jonathan Peterson’s picture

Jonathan Peterson commented
Status: Needs review » Needs work

Short and sweet, code is well documented, passes standards, module does exactly what it says it does and no more. Nice.

My requested changes:

  • feedbackify.info needs version number
  • No longer necessary to include the CVS tag $Id: $; please remove
  • Rename "colour" to "color"; american english is the standard
  • Color needs a validation check
  • Line 44 $script .= should be $script=

Questions/suggestions:

  • Consider creating a new privilege 'administer feedbackify' rather than use the general administrator priv
  • It'd be nice to have a jquery colorwheel on the color selector
  • Add description to color field that empty string means it'll be transparent
Jonathan Peterson’s picture

Jonathan Peterson commented

Actually I thought of another item:

You need an uninstall hook to remove the feedbackify variables.

jthorson’s picture

jthorson commented

One correction ...

The 'version' number will be added to the .info file by the packaging script ... no need to add it. :)

ivanbreet’s picture

ivanbreet commented
Status: Needs work » Fixed

Thank you for taking your time to review this module.

I made all requested changes, added uninstall hook to remove the Feedbackify variables and implemented two of your suggestions.

I will work on the color module integration, and include it in one of the future updates :)

jthorson’s picture

jthorson commented
Status: Fixed » Needs review

ivanbreet,

As per the project application workflow, the status of your application should toggle between 'needs work' and 'needs review' until a reviewer marks it as 'RTBC'.

The 'Fixed' status is reserved for when the review has been completed and a git administrator has granted you the 'full project' role.

Jonathan Peterson’s picture

Jonathan Peterson commented
Status: Needs review » Reviewed & tested by the community

Looks good; setting to reviewed and tested.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Reviewed & tested by the community » Fixed

git vetted user role granted. Welcome, thanks for your current and future contributions, and thanks to all for reviewing.

Please make sure to review other applications in the queue so we can eventually get it down.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

Oh - I forgot to mention -

* I recommend you delete the files in your master branch and replace with a README.please_look_in_named_branches.txt
* There's a typo "trail' => "trial" at the end of your readme.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

ned006’s picture

ned006 commented

That's great, but there are plenty of free tools out there you can take advantage of these days. My favorite is voicewith - their buttons aren't as customizable but I was able to put a button up in less than a minute.