Commerce DIBS is a payment module to integrate DIBS with Drupal Commerce.

http://drupal.org/sandbox/MaxOne/1178080

Comments

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
Status: Needs review » Needs work

Thanks for your contribution to Drupal & Drupal Commerce, and sorry for the long wait!

The module seems well developed and following Drupal and Drupal Commerce standards (there are a few minor issues when running Coder that you might check).

Only remark:
I'm not sure it's good practice to specify your own acceptance page. This might interfere with extra rules that could be set up in the site. If you want a custom acceptance page, it would be best to implement that separate from any specific payment provider. You might want to check in the Drupal Commerce queue or #drupal-commerce on IRC to get confirmation on this... In case you do keep the page, you should probably return a renderable array instead (http://drupal.org/node/224333#menu_callback_array) in the callback function.

MaxOne’s picture

MaxOne commented

Hi.

Thank you for your review!

When i run Coder, i get the message "Coder found 1 projects, 2 files, 0 warnings were flagged to be ignored". Is it something i'm missing?

The reason i chose to make an acceptance page is that DIBS way of showing if the transaction is accepted or denied is to redirect you to either a "denied-URL" or to an "accept-URL".

I made a few minor changes to the function commerce_dibs_accept_page(), which now returns a renderable array. Is it ok to print out the order number as #suffix ?

MaxOne’s picture

MaxOne commented
Status: Needs work » Fixed

Changing the status.

torvall’s picture

torvall commented
Status: Fixed » Needs review

MaxOne, you need to set the status to "needs review" instead of "fixed" to have the module reviewed again after you've addressed the issues pointed out. Check out the "Project Application Workflow" section on this document.

Regarding the use of the coder module, you should set it to "minor (most)" in the Reviews section of the selection form.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work

* What is DIBS? provide more information on your project page.
* Git release branch missing, see http://drupal.org/node/1015226
* README should be README.txt
* no need to list commerce as dependency, I'm sure the other dependencies depend on it anyway
* module file: @file doc block is missing, see http://drupal.org/node/1354#files
* "Implementation of hook_theme()." this should be "Implements hook_theme()". Also elsewhere.
* "'orderid' => array( ..." indentation error, always use 2 spaces for any level
* "// Accept url for processing successful payments" comments should end with "."

MaxOne’s picture

MaxOne commented
Status: Needs work » Needs review

Thank you torvall and klausi.

I think i've fixed all the issues now.

sreynen’s picture

sreynen commented
Status: Needs review » Postponed

Hi MaxOne,

http://drupal.org/project/dibs says "The Drupal 7 version is distributed with a payment module for Drupal Commerce." Is this module still useful?

We can approve this application and give you full project access regardless, but I'm setting this to postponed to clarify the status of the project first.

MaxOne’s picture

MaxOne commented

Hi sreynen.

When I first posted this project, that module had no support for Drupal Commerce, apparently it does now. So no, my module is probably not necessary anymore.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Postponed » Closed (won't fix)

So I suggest that you join forces with the maintainer of that module. I mark this particular issue as "won't fix", but don't worry: you can of course open another project application issue if you have other ideas.