If you edit a node with another revision that adds another file, or removes the first file, on node view, you will see both files.

CommentFileSizeAuthor
#1 1178296-pift-show-node-revision-files-only.patch968 bytesdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 1178296-pift-show-node-revision-files-only.patch968 bytes
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs review » Reviewed & tested by the community

Tested and working on http://metrics-drupal.redesign.devdrupal.org/ Hooray!

On review, I pointed out to Dave that the node_load() there is an expensive way to get at a single property of the node, but he pointed out that pift_comment_load_node() is already loading the node, so this will just be returned from cache.

Looks good to me!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

This is the problem this patch is attempting to fix (in an issue body):

Only local images are allowed.

boombatower’s picture

boombatower commented

subscribe, I'll try and take a look.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Reviewed & tested by the community » Fixed

Looks perfect to me. Committed: 1270a1a845156d37d0943074070fcbd17dc78a3c

boombatower’s picture

boombatower commented

That works too :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.