When pasting a date like "2010-07-03" into the "Date begin" and/or "Date end" field, the date is reset to "1970-01-01" when saving the node. I have ro (re-) edit every project node a second time, paste date begin and end dates again, and then save a second time - then the modules stores the values correctly.

Also, the "project" node view is missing the begin and end dates, it simply doesn't show them in node display.

Opposed to that, empty fields (like "Step no.: ") are not properly collapsed when they do not contain any value (might or might not be intended, I don't know).

When the user chooses to disable the node body field (and, for example, use a more flexible CCK field insted), this is as well not properly collapsed in the node display.

CommentFileSizeAuthor
#12 Create Invoice Page after applying the patch.png132.14 KBd34dman

Comments

asb’s picture

asb commented

Also the tabular task listing (at /storm/tasks/?project_nid=21 does neither show the begin/end dates, nor the node cration date. Thus it's necessary to edit the node to display the begin/end dates (for which the user might not even have śufficient permissions).

The tabular listing also does not allow to sort the task listing by any chronolgy, and it's not clear which primary sort criteria it uses at all. It'd be really easiser if those listings would be built with (editable) views.

asb’s picture

asb commented

Short addition: It seems that the begin/end dates are not only reset to "1970-01-01" when pasting a date value, but always on the first save. So basically this module seems to never save the entered date values correctly by default.

I think it can't get much worse for time tracking a project with start and end dates before most clients were even born ;-/

Workaround: Edit the node three times:

  1. Enter some date values. Doesn't matter which, it'll be "1970-01-01" anyway
  2. Edit again, now enter the proper star/end dates
  3. Edit once more, to check if the values were stored properly this time (remember, in node view the star/end date values aren't displayed at all)
juliangb’s picture

juliangb commented
Status: Active » Postponed (maintainer needs more info)

I've just done a quick test on this and it worked fine for me. Are you using other contrib modules such as date api and/or date popup?

asb’s picture

asb commented
Status: Postponed (maintainer needs more info) » Active

Yes. Date API 6.x-2.7, Date Popup 6.x-2.7, and Date Timezone 6.x-2.7.

Probably related: #1153672: Missing Date API for Views

asb’s picture

asb commented

This date issue is a nightmare as Nodes created by 'Storm' are simply not reliable. Now I'm getting also bogus dates like "2038-01-19".

Working with invalid dates is kind of worst case for a project management and time tracking application. "As is", 'Storm' is pretty much useless if not even harmful.

Any chances tht this will get fixed?

d34dman’s picture

d34dman commented

i am also havehaving this problem... but still not able to pinpoint the exact place where dates are getting lost in between node submit and node save. Yes this makes the task unusable for me atm.

asb’s picture

asb commented

Don't use Date popups, 'Storm' seems to be incompatible with (at least) portions of the CCK 'Date' module.

d34dman’s picture

d34dman commented

Hi asb that would be a temporary solution. yes.

Now that would automatically trigger a bug in my module.

I guess the issue is supposedly fixed in #787822 but thats for 2.x branch... the mantra is persuade i guess. :)

In this issue Dependency date_popup, kfritsche has suggested i use dateext type input (implemented by storm) to input date. While implementing this i understood what was need to get it working.

Its actually three select list input of type array that is to be converted to date string and used. So while displaying it in the node edit form the re-conversion is required.

something like.
A. Node create.
==========================
1. three select list - year month and day (on node edit form)
2. an array ( in form submit)
3. convertion to datestring
4. save this date string to database.
==========================

B. Node view
==========================
1. Fetch datestring from database
2. Display it to user according to certain format
==========================

C. Node edit form
==========================
1. Fetch datestring from database
2. Split time into year, month and day.
3. populate the defaults in select list
4. Display it to user --- user interation ------
5. an array ( in form submit)
6. convertion to datestring
7. save this datestring to database.
==========================

Looking at the above steps you can see what can go wrong if stes C2/C3 fails. The dateext fields presented at C4 will have wrong value like 0 (zero in unix timestamp would be 01-01-1970). But honestly i must confess i fail to understand how date popup interacts with dateext.

I think it has to be somewhere arround A1, A2, C4 and C5. If somebody could edit above steps to correct me if i am wrong or even better add how date popup's role in A1, A2, C4 and C5.

kfritsche’s picture

kfritsche
Primary language German
Location 🇩🇪🇪🇺
commented

Basically the steps from D34dMan are right, except of the fact storm saves the unix timestamp instead of a date string.
The difference between the 3 select fields and the date popup is, that the timestamp is converted to an string instead of an array.
Like juliangb, i also have no problems with the current storm-1.36 release, but it is only a sandbox project, for testing purpose (so it is empty), because i normally use storm-2.x-dev.
I have the date_popup module enabled.
Can someone help me out, how to reproduce this bug?
I created one project, one task and a ticket. All dates are still there. In the ticket form i only have select fields, in task/project i have the date popup, like described #787822: Implement support for Date popup module on Ticket and Invoice Date Fields, but it works for me.

d34dman’s picture

d34dman commented

Hi kfritsche,

i recall having had issues with weird dates (in storm and as well as in real life :( ) when i used to enter duration only. In both cases unexpected dates turned up (1970-01-01). Next time it happens i will take a take a picture and post it in here. Oh and don't worry i would only bother you about dates in storm :).

kfritsche’s picture

kfritsche
Primary language German
Location 🇩🇪🇪🇺
commented
Status: Active » Needs review

Anyone tested the patch in #787822: Implement support for Date popup module on Ticket and Invoice Date Fields for the 1.x?
If #787822: Implement support for Date popup module on Ticket and Invoice Date Fields fixes this issue too, maybe we should add this to the 1.x Branch.
But I do not have Storm 1.x running somewhere, so its hard for me to test.
Any reports would be nice.
Setting this to needs review as the Issue #787822 needs review, to be commited to 1.x and should fix this Bug too.

d34dman’s picture

d34dman commented
StatusFileSize
new Create Invoice Page after applying the patch.png132.14 KB

Tried to apply the patch manually but it failed. It appeared to me that the patch was written switch between two folders mainly a/storm and b/storm... so whenever it prompted for missing files.. i just manually entered the filenames as shown below....

$ patch -p0 < date_popup_integration-787822-44.patch
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/storm.css b/storm.css
|index 3830d48..d9c2f4d 100644
|--- a/storm.css
|+++ b/storm.css
--------------------------
File to patch: storm.css
patching file `storm.css'
Hunk #1 succeeded at 165 (offset 1 line).
can't find file to patch at input line 18
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/storm.module b/storm.module
|index 29dff15..7f6468d 100644
|--- a/storm.module
|+++ b/storm.module
--------------------------
File to patch: storm.module
patching file `storm.module'
Hunk #1 succeeded at 343 (offset 1 line).
Hunk #2 FAILED at 422.
1 out of 2 hunks FAILED -- saving rejects to storm.module.rej
can't find file to patch at input line 177
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/stormexpense/stormexpense.module b/stormexpense/stormexpense.modul
e
|index f90513e..2da649a 100644
|--- a/stormexpense/stormexpense.module
|+++ b/stormexpense/stormexpense.module
--------------------------
File to patch: stormexpense/stormexpense.module
patching file `stormexpense/stormexpense.module'
Hunk #1 succeeded at 433 (offset 1 line).
can't find file to patch at input line 193
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/storminvoice/storminvoice.module b/storminvoice/storminvoice.modul
e
|index b6ffe56..7a3a088 100644
|--- a/storminvoice/storminvoice.module
|+++ b/storminvoice/storminvoice.module
--------------------------
File to patch: storminvoice/storminvoice.module
patching file `storminvoice/storminvoice.module'
Hunk #1 succeeded at 433 (offset 1 line).
can't find file to patch at input line 222
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/stormproject/stormproject.module b/stormproject/stormproject.modul
e
|index 7950c1b..64699c0 100644
|--- a/stormproject/stormproject.module
|+++ b/stormproject/stormproject.module
--------------------------
File to patch: stormproject/stormproject.module
patching file `stormproject/stormproject.module'
Hunk #1 succeeded at 418 (offset 1 line).
can't find file to patch at input line 271
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/stormtask/stormtask.module b/stormtask/stormtask.module
|index 4ede737..822fa08 100644
|--- a/stormtask/stormtask.module
|+++ b/stormtask/stormtask.module
--------------------------
File to patch: stormtask/stormtask.module
patching file `stormtask/stormtask.module'
Hunk #1 succeeded at 599 (offset 1 line).
can't find file to patch at input line 313
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/stormticket/stormticket.module b/stormticket/stormticket.module
|index 7c384c3..40bf0bc 100644
|--- a/stormticket/stormticket.module
|+++ b/stormticket/stormticket.module
--------------------------
File to patch: stormticket/stormticket.module
patching file `stormticket/stormticket.module'
Hunk #1 succeeded at 488 (offset 1 line).
can't find file to patch at input line 334
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/stormtimetracking/stormtimetracking.module b/stormtimetracking/sto
rmtimetracking.module
|index 219c9bc..74abef2 100644
|--- a/stormtimetracking/stormtimetracking.module
|+++ b/stormtimetracking/stormtimetracking.module
--------------------------
File to patch: stormtimetracking/stormtimetracking.module
patching file `stormtimetracking/stormtimetracking.module'
patch unexpectedly ends in middle of line
Hunk #1 succeeded at 439 with fuzz 1 (offset 1 line).

But the patch broke the site.

:(

d34dman’s picture

d34dman commented
Status: Needs review » Needs work
juliangb’s picture

juliangb commented
Version: 6.x-1.36 » 6.x-1.x-dev

D34dMan, thanks for reviewing.

Can I suggest you use git apply to test the patches? It might apply with less manual intervention.

See http://drupal.org/node/253481/git-instructions/6.x-2.x/nonmaintainer for more details...

d34dman’s picture

d34dman commented
Status: Needs work » Needs review

Hi there,
i think you dont want me to patch and test 2.x version ? it fails... testing for 1.x...

so far patch could be applied.... reviewing it..

$ git apply -v date_popup_integration-787822-44.patch
Checking patch storm.css...
Checking patch storm.module...
Checking patch stormexpense/stormexpense.module...
Checking patch storminvoice/storminvoice.module...
Checking patch stormproject/stormproject.module...
Hunk #1 succeeded at 421 (offset 4 lines).
Hunk #2 succeeded at 866 (offset 4 lines).
Checking patch stormtask/stormtask.module...
Hunk #1 succeeded at 602 (offset 4 lines).
Checking patch stormticket/stormticket.module...
Hunk #1 succeeded at 491 (offset 4 lines).
Checking patch stormtimetracking/stormtimetracking.module...
Applied patch storm.css cleanly.
Applied patch storm.module cleanly.
Applied patch stormexpense/stormexpense.module cleanly.
Applied patch storminvoice/storminvoice.module cleanly.
Applied patch stormproject/stormproject.module cleanly.
Applied patch stormtask/stormtask.module cleanly.
Applied patch stormticket/stormticket.module cleanly.
Applied patch stormtimetracking/stormtimetracking.module cleanly.
juliangb’s picture

juliangb commented

That's right - this is for 1.x.

The patch has already been applied to 2.x.

d34dman’s picture

d34dman commented
Status: Needs review » Needs work

the date popup appears as expected... but on each time i save the node, the date is getting shifted by "MINUS 1 Day".

thus if i use date popup to fill 1st Dec 2011 in the date field, on save it becomes 1324665000 converted to Friday, December 23rd 2011, 18:30:00 (GMT).

d34dman’s picture

d34dman commented

continuing the discussion in this issue where i feel it is more apporpriate...

________________________________________________________________________________________________
EDIT NOTE: the link was pointing to the same page, now its corrected to point to intended issue.

kfritsche’s picture

kfritsche
Primary language German
Location 🇩🇪🇪🇺
commented
Status: Needs work » Needs review

As #787822: Implement support for Date popup module on Ticket and Invoice Date Fields is fixed for 1.x, this should fix this bug to.

d34dman’s picture

d34dman commented

I cannot reproduce the bug.

juliangb’s picture

juliangb commented
Status: Needs review » Fixed

I've just tested too and cannot reproduce. Given that and D34dMan's report, I'll assume this is fixed.

If anyone is still having trouble, please post exact steps / modules to reproduce.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.