Download & Extend
Link » Issues

Support custom TLDs from the current hostname

Posted by manarth on June 6, 2011 at 11:28am
Project:Link
Version:7.x-1.0-alpha3
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (works as designed)

Issue Summary

I'm working on an intranet site, where all the LAN domains use the format foo.bar.lan.
The link module prevents users from adding internal links, because .lan is not a valid TLD.

This patch allows administrators to make URL validation optional (but defaults to require-validation, to avoid changing the current default behaviour).

AttachmentSize
link.make_url_validational_optional.patch1.39 KB
Login or register to post comments

Comments

#1

Posted by jcfiala on June 6, 2011 at 12:36pm

I hate to say it after you've gone through all this work, but have you checked the dev version? I've got optional url validation there.

That being said, the idea of having custom tld isn't a bad one.

#2

Posted by DamienMcKenna on September 19, 2011 at 2:49pm
Title:Make URL validation optional» Support custom TLDs from the current hostname

Refocusing this issue: the module should also allow the site's current hostname as a valid domain, regardless of TLD.

#3

Posted by Digidog on September 19, 2011 at 7:10pm

@ DamienMcKenna: did you check latest dev already?

#4

Posted by MrHaroldA on February 7, 2012 at 2:57pm

The link module prevents users from adding internal links, because .lan is not a valid TLD.

Although .lan isn't a valid TLD, I'd really like to be able to use it in a link field as we use it for local machines and internal servers.

Expanding LINK_DOMAINS with a variable_get() would be sufficient in our case...

#5

Posted by Digidog on February 15, 2012 at 2:18am
Status:needs review» closed (works as designed)

I still don't get it. You can turn off URL validation in link module since ages. Why don't you simply turn it off? If you want to use custom urls with fantasy strings, I don't understand what this issue here is for, nor for what you need url validating then turned on or worked around with any patch?

URL validating is for "VALID" urls, thats what it is for namely and will ever be. If your hostname is home_kitchen#+ß09990ß//-### you simply can't use URL validation.

If you want a custom string validation tool for your custom enviroment, feel free to open an issue for that, but URL validation works as designed.

Sorry, and thanks for understanding ...

#6

Posted by MrHaroldA on February 15, 2012 at 9:43am

Well, I'd like our users to put in a TLD of their choice, but it does have to be formatted like a url: 'http://domain.tld|local|lan'

Without nagging: an option to use Drupal's valid_url() instead of link's url validator will suffice...