Zero or Blank limit, should display all entries in a search facet block.

It's not doing that and instead setting it to a limit of 0, so nothing shows up.

I've made a patch to correct this behaviour.

From the form item when configuring the block

Number of terms
The maximum number of facet terms to be initially displayed in this block. Leave blank or set to 0 for no limit.

CommentFileSizeAuthor
#1 search_api_facet_limit-1179990.patch967 bytesj0rd
search_api_facet_limit.patch1.6 KBj0rd

Comments

j0rd’s picture

j0rd commented
StatusFileSize
new search_api_facet_limit-1179990.patch967 bytes

Oops, that patch I've included also has a fix for wysiwyg module. Sorry. Here's a proper patch.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Title: Search API Facet block not respecting Zero or Blank limit to display unlimited. Instead showing Zero. » Facet blocks don't correctly respect the "unlimited" setting
Status: Needs review » Fixed

Ah, you're right of course. Seems to have been caused by #1049978: Provide a "More" link for facets.
The patch seems to work fine, thanks! Committed it.

By the way, please create patches relative to the module directory, not to your web server's root directory. They should be able to be applied with git apply PATCH.

j0rd’s picture

j0rd commented

Any idea how to create a patch from the module directory? I'm getting yelled at in other issue queues for these types of patches too :)

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented

Um, yes, just change the directory to the module directory before creating the patch?
It depends on your local setup and how you create the patches, though, which in your case seems a bit strange. But I guess even if you have a large Git repository for the whole web server, you'll also have individual repositories for all modules. So just changing to the directory should work. If you aren't creating the patch on the command line, it wholly depends on the program you're using.

j0rd’s picture

j0rd commented

@dm PM time, but thanks for the insight.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.