pMailer Newsletter Directory

Project sandbox link, for future reference: http://drupal.org/sandbox/prefix_account/1179876

Some comments:

• Check your .info file against the .info recommendations; specifically, you shouldn't set a version, and you don't need to include the .info and .module in files[].
• Check your module's formatting with the Coder module. For example, your bracing is off, since opening braces go on the same line as the function declaration. Just ignore Coder when it tells you to add $Id$ lines, since they're not necessary with git anymore.
• You need to use hook_permission to declare the permissions your module uses so they can be edited in the Drupal administration pages.
• On line 76 of pmailer_directory.module: if ($api_key & $pMailer_server) will have unexpected results, since & is bitwise AND, rather than logical AND. You want &&.
• All your module's functions should be prefixed with pmailer_directory_. For example, archieve() should be pmailer_directory_archieve().
• reload_archieve() should escape variables with check_plain() before dumping them into raw HTML, unless the data is already escaped.
• And finally, it's spelled "archive", not "archieve."

I hope this helps you improve your module. Once you've fixed these issues, set the status back to "needs review" and someone will take another look through.

No activity in several months. Reopen and set the status to "needs review" if you are still pursuing this application.